From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.groups.io with SMTP id smtpd.web08.3183.1635284260670611484 for ; Tue, 26 Oct 2021 14:37:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=aIXuEaCv; spf=pass (domain: nuviainc.com, ip: 209.85.128.50, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f50.google.com with SMTP id 131-20020a1c0489000000b0032cca9883b5so3147480wme.0 for ; Tue, 26 Oct 2021 14:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I6+IQq+N+MVEe+wQ2VkAaSXUhtOYP03Xyb7uYrrNSsg=; b=aIXuEaCvwgAIvX4ViHGR3V5qJbRg37p4kiK5FFB+B+GtFju40tTYA+USZP2QD1wOPB q396ifw362Ew37VvbE/NY+PeR7F3MQljHq4tv0mbcTmzCMNp0kutqO3xS6SWg7oW9ydZ /G0R2NPMRGmEOl1J1UOtwMNFW9Jzv/ZFTcPIsCxu2MMgQiR8pnaHgV7BcRX7ElWcykWC 3tftp+oAgbA2D+kP2Y7ijCmMaA5Sybuf5ipIeU+R0gARbW/HRafyyZFxrfAmCprft3vC xKRvFFZr0g/6qyVeTaVArOBjaB7gjwDf2EtaD+w0Zv+WsdlIQUApuiHX1gii3PERGcwg LLdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I6+IQq+N+MVEe+wQ2VkAaSXUhtOYP03Xyb7uYrrNSsg=; b=3fqLdDGFSdeR20/H3L8K9r7x3te/OXNX+EGOGpXb6EOF/4b8h3FRpZbQa5LIand1MF muMGVceVHfPPm4bcYX+ls1YUSUNtwCqPHl8VmecG3/n+kHflOSXUcoUQUEB0UMiW9dOr NkEepIL13CkonLneYkcWhmVvegQI9l0ocWJonKuuKFFdeXn2vx+xbYfDjrKl/EJSarKY A1E9/oczAsXP2C1PDaU/r5z3MGL0NjyZmkTNZ5DmmuGotBmgAHpaxj9unIzt7IJ8u2cY cgitWv6rWBF2vvPWc+ptE3SKovyT0XzpZZ0h0ziAW01wIe430IH0nBRPes0AwO9V9hkb sWxQ== X-Gm-Message-State: AOAM532FEp0Sx1HJZvPMgGDWtzA3LoJNLyTcN3q+f/N+jleS38AdBsE1 V0ZE5/2lIXbajpn/RPnJwe/r/Q== X-Google-Smtp-Source: ABdhPJywyDLeZTsPB4JJy0fJCUagBZyf4VlP4bvcozawYaVwZrS1tLkq/oqh9Y5hv5ITYCQGfMV5sw== X-Received: by 2002:a1c:a186:: with SMTP id k128mr1429410wme.6.1635284259145; Tue, 26 Oct 2021 14:37:39 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id g77sm1953562wmg.31.2021.10.26.14.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 14:37:38 -0700 (PDT) Date: Tue, 26 Oct 2021 22:37:36 +0100 From: "Leif Lindholm" To: Pierre Gondois Cc: devel@edk2.groups.io, Ard Biesheuvel , Sean Brogan , Sami Mujawar , Ard Biesheuvel Subject: Re: [edk2-devel] [RFC PATCH edk2-platforms v1 0/5] Remove ARM nested packages Message-ID: <20211026213736.bl6k7w72aqotokbe@leviathan> References: <20211019102502.3765-1-Pierre.Gondois@arm.com> <16AF6AC06BB23F23.2978@groups.io> <57a0d229-fb65-4a89-d4bd-5f5c3bf1ec9d@arm.com> MIME-Version: 1.0 In-Reply-To: <57a0d229-fb65-4a89-d4bd-5f5c3bf1ec9d@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Pierre, This patchset is an unambiguous improvement on the current state, and improves the state of Platform/ARM substantially. For the series: Acked-by: Leif Lindholm / Leif On Tue, Oct 26, 2021 at 15:06:28 +0100, Pierre Gondois wrote: > Hi Leif, > > This patch-set resolves: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3259 > > without removing the Platform/ARM prefix used in the Platform/ARM/ folder (cf https://bugzilla.tianocore.org/show_bug.cgi?id=3264). Does it look sensible ? > > Regards, > Pierre > > > On 10/19/21 12:22, PierreGondois via groups.io wrote: > > Hi Ard, > > > > On 10/19/21 12:17, Ard Biesheuvel wrote: > >> On Tue, 19 Oct 2021 at 12:25, wrote: > >>> From: Pierre Gondois > >>> > >>> Bugzilla: 3259 (https://bugzilla.tianocore.org/show_bug.cgi?id=3259) > >>> > >>> The Platform/ARM/ARM.dec file implies that the Platform/ARM/ folder is > >>> a package. This folder however hosts other packages describing > >>> platforms (JunoPkg, SgiPkg, ...) and packages describing drivers > >>> (BootMonFs, FdtPlatformDxe). > >>> > >>> As the Dec specification mention: > >>> "EDK II Packages cannot be nested within other EDK II Packages." > >>> Also, CI modules are based on packages. Having non-nested packages > >>> allows to have distinct entities each CI module must check. > >>> > >>> To remove the nested structure: > >>> 1- Create a Platform/ARM/ArmCommonPkg package containing code > >>> shared among platforms. It will contains the following folders: > >>> Platform/ARM/[Drivers/ | Include/ | Library/] > >>> 2- Remove the BootMonFs and FdtPlatformDxe packages and resolve > >>> the broken dependencies to these drivers > >>> 3- Resolve the broken dependencies to the libraries from > >>> Platform/ARM/Library > >>> > >>> Some remarks: > >>> - This patch-set doesn't remove the Platform/ARM prefix. > >>> - Building an ARM Platform after applying a subset of > >>> the patch-set would fail. Thus, if accepted, the > >>> patch-set should be squashed as one single patch. > >>> > >>> Pierre Gondois (5): > >>> Platform/ARM: Create ArmCommonPkg > >>> Platform/ARM: Create ArmCommonPkg.dec from ARM.dec > >>> Platform/ARM: Move BootMonFs package to ArmCommonPkg > >>> Platform/ARM: Move FdtPlatformDxe package to ArmCommonPkg > >>> Platform/ARM: Resolve ArmCommonPkg library references > >>> > >> Thanks for this, and apologies for the radio silence after the first > >> time you submitted this. > >> > >> Are there any differences between this version and the one you posted before? > > No worries, the difference is that the other patch-set was also > > resolving this bugzilla: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3264 > > > > This path set only solves this one: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3259 > > > >> > >>> Platform/ARM/ARM.dec | 22 ------------------- > >>> .../ArmCommonPkg.dec} | 18 +++++++++++++-- > >>> .../Drivers/BootMonFs/BootMonFs.inf | 3 +-- > >>> .../Drivers/BootMonFs/BootMonFsApi.h | 0 > >>> .../Drivers/BootMonFs/BootMonFsDir.c | 0 > >>> .../Drivers/BootMonFs/BootMonFsEntryPoint.c | 0 > >>> .../Drivers/BootMonFs/BootMonFsHw.h | 0 > >>> .../Drivers/BootMonFs/BootMonFsImages.c | 0 > >>> .../Drivers/BootMonFs/BootMonFsInternal.h | 0 > >>> .../Drivers/BootMonFs/BootMonFsOpenClose.c | 0 > >>> .../Drivers/BootMonFs/BootMonFsReadWrite.c | 0 > >>> .../Drivers/BootMonFs/BootMonFsUnsupported.c | 0 > >>> .../Drivers/FdtPlatformDxe/FdtPlatform.c | 0 > >>> .../Drivers/FdtPlatformDxe/FdtPlatform.h | 0 > >>> .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 3 +-- > >>> .../Drivers/FdtPlatformDxe/FdtPlatformDxe.uni | 0 > >>> .../Drivers/FdtPlatformDxe/README.txt | 0 > >>> .../Drivers/FdtPlatformDxe/ShellDumpFdt.c | 0 > >>> .../Drivers/FdtPlatformDxe/ShellSetFdt.c | 0 > >>> .../Include/Guid/BootMonFsFileInfo.h | 0 > >>> .../Include/Library/ArmShellCmdLib.h | 0 > >>> .../Include/Library/BdsLib.h | 0 > >>> .../Library/ArmShellCmdRunAxf/AArch64/Pivot.S | 0 > >>> .../Library/ArmShellCmdRunAxf/Arm/Pivot.S | 0 > >>> .../ArmShellCmdRunAxf/ArmShellCmdRunAxf.c | 0 > >>> .../ArmShellCmdRunAxf/ArmShellCmdRunAxf.h | 0 > >>> .../ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf | 2 +- > >>> .../ArmShellCmdRunAxf/ArmShellCmdRunAxf.uni | 0 > >>> .../ArmShellCmdRunAxf/BootMonFsLoader.c | 0 > >>> .../ArmShellCmdRunAxf/BootMonFsLoader.h | 0 > >>> .../Library/ArmShellCmdRunAxf/ElfLoader.c | 0 > >>> .../Library/ArmShellCmdRunAxf/ElfLoader.h | 0 > >>> .../Library/ArmShellCmdRunAxf/RunAxf.c | 0 > >>> .../Library/ArmShellCmdRunAxf/elf32.h | 0 > >>> .../Library/ArmShellCmdRunAxf/elf64.h | 0 > >>> .../Library/ArmShellCmdRunAxf/elf_common.h | 0 > >>> .../Library/BdsLib/BdsFilePath.c | 0 > >>> .../Library/BdsLib/BdsHelper.c | 0 > >>> .../Library/BdsLib/BdsInternal.h | 0 > >>> .../Library/BdsLib/BdsLib.inf | 2 +- > >>> Platform/ARM/Drivers/BootMonFs/BootMonFs.dec | 20 ----------------- > >>> Platform/ARM/JunoPkg/ArmJuno.dsc | 4 ++-- > >>> Platform/ARM/JunoPkg/ArmJuno.fdf | 4 ++-- > >>> .../JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 3 +-- > >>> Platform/ARM/Morello/MorelloPlatformFvp.fdf | 2 +- > >>> Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 2 +- > >>> Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +- > >>> .../ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 4 ++-- > >>> .../ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 4 ++-- > >>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 4 ++-- > >>> .../Drivers/ArmVExpressDxe/ArmFvpDxe.inf | 2 +- > >>> .../Drivers/ArmVExpressDxe/ArmHwDxe.inf | 2 +- > >>> 52 files changed, 36 insertions(+), 67 deletions(-) > >>> delete mode 100644 Platform/ARM/ARM.dec > >>> rename Platform/ARM/{Drivers/FdtPlatformDxe/FdtPlatformDxe.dec => ArmCommonPkg/ArmCommonPkg.dec} (52%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFs.inf (90%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsApi.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsDir.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsEntryPoint.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsHw.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsImages.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsInternal.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsOpenClose.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsReadWrite.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/BootMonFs/BootMonFsUnsupported.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/FdtPlatformDxe/FdtPlatform.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/FdtPlatformDxe/FdtPlatform.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf (89%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/FdtPlatformDxe/README.txt (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/FdtPlatformDxe/ShellDumpFdt.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Drivers/FdtPlatformDxe/ShellSetFdt.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Include/Guid/BootMonFsFileInfo.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Include/Library/ArmShellCmdLib.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Include/Library/BdsLib.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/AArch64/Pivot.S (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/Arm/Pivot.S (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf (91%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.uni (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/BootMonFsLoader.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/BootMonFsLoader.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/ElfLoader.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/ElfLoader.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/RunAxf.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/elf32.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/elf64.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/ArmShellCmdRunAxf/elf_common.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/BdsLib/BdsFilePath.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/BdsLib/BdsHelper.c (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/BdsLib/BdsInternal.h (100%) > >>> rename Platform/ARM/{ => ArmCommonPkg}/Library/BdsLib/BdsLib.inf (92%) > >>> delete mode 100644 Platform/ARM/Drivers/BootMonFs/BootMonFs.dec > >>> > >>> -- > >>> 2.17.1 > >>> > > > > > > > >