public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting.
@ 2021-10-27  6:56 Tan, Ming
  2021-11-04  5:21 ` [edk2-devel] " Attar, AbdulLateef (Abdul Lateef)
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Tan, Ming @ 2021-10-27  6:56 UTC (permalink / raw)
  To: devel

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3708

The original code will cause FWTS V21.08.00 testing failed.
 spcr: SPCR PC-AT compatible IRQ 0xff is invalid
 spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device

Now modify the SpcrAcpi for following:
1. Disable the support of PC-AT compatible IRQ support.
   Now only support IO-APIC interrupt type.
2. Set irq to 0.
3. Set the GSI to the value read from PCI device cfg space 0x3C.
4. Set PCI Flags to 1.

Signed-off-by: Ming Tan <ming.tan@intel.com>
---
  V2: Fix a typo

 .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c                    | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
index 86c40e90b8..7ad0c058c8 100644
--- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
+++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
@@ -324,7 +324,9 @@ GetPciTypeInfo (
   }
 
   gSpcrInfo.BaseAddress.Address = BaseAddress;
-  gSpcrInfo.Irq = (UINT8) Irq;
+  gSpcrInfo.InterruptType = EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_APIC;
+  gSpcrInfo.Irq = 0;
+  gSpcrInfo.GlobalSystemInterrupt = (UINT32)Irq;
 
   gSpcrInfo.PciDeviceId       = DeviceId;
   gSpcrInfo.PciVendorId       = VendorId;
@@ -332,6 +334,7 @@ GetPciTypeInfo (
   gSpcrInfo.PciDeviceNumber   = (UINT8) Device;
   gSpcrInfo.PciFunctionNumber = (UINT8) Function;
   gSpcrInfo.PciSegment        = (UINT8) SegNum;
+  gSpcrInfo.PciFlags          = 1;
 
 Done:
   if (Resources != NULL) {
-- 
2.29.2.windows.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-02  0:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-27  6:56 [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting Tan, Ming
2021-11-04  5:21 ` [edk2-devel] " Attar, AbdulLateef (Abdul Lateef)
2021-11-04  5:45   ` Tan, Ming
2021-12-02  0:48 ` Nate DeSimone
2021-12-02  0:56 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox