From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web10.8416.1635319184815893773
 for <devel@edk2.groups.io>;
 Wed, 27 Oct 2021 00:19:45 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SnH+OmzC;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1635319183;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Hb8EWJfQgd3Yhs8f9bVEDsniYrDhnAYO3IUPAt9SXj0=;
	b=SnH+OmzCJhq2wkVV6nQsazf4BskaRuNaYS3f9BQwGP5Pb8Cmu6wZrlwjF2aAr/A4+n5DSZ
	4ADBVXC16BUNzY2W5xkw5/0lpX3gPUzO9LXz57jqsV3tGq5A/cUDGbSFHJjjZjqH/pT7Br
	0FIQ2y5H2E67co3pdKHPG6sJGsi2Djo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-325-f___kdB6PnSyULyMNUuAmw-1; Wed, 27 Oct 2021 03:19:39 -0400
X-MC-Unique: f___kdB6PnSyULyMNUuAmw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE16F1808304;
	Wed, 27 Oct 2021 07:19:37 +0000 (UTC)
Received: from sirius.home.kraxel.org (ovpn-112-241.phx2.redhat.com [10.3.112.241])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 55A5C1816A;
	Wed, 27 Oct 2021 07:19:37 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7B5EB18007B7; Wed, 27 Oct 2021 09:19:35 +0200 (CEST)
Date: Wed, 27 Oct 2021 09:19:35 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception
Message-ID: <20211027071935.a4l3aiiu6uaaqdvl@sirius.home.kraxel.org>
References: <cover.1633401643.git.min.m.xu@intel.com>
 <24d3a351f21bff1a4b20490313d039e403b1453c.1633401643.git.min.m.xu@intel.com>
 <20211012102716.wr6bao42f5hviz5z@sirius.home.kraxel.org>
 <PH0PR11MB50649BC1303B39C3054F7054C5849@PH0PR11MB5064.namprd11.prod.outlook.com>
 <20211026061148.omqerrswnpgs3jin@sirius.home.kraxel.org>
 <PH0PR11MB5064DBBEDB455EF8B1C2D81FC5849@PH0PR11MB5064.namprd11.prod.outlook.com>
 <20211026102458.pvzp5nxyegq7ftuu@sirius.home.kraxel.org>
 <PH0PR11MB50648067C27ABED05A665CBCC5849@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB50648067C27ABED05A665CBCC5849@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > How about adding the tdx exception handler to the existing library, so we don't
> > have the churn of adding a new library everywhere *again*?

> Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in CpuExceptionHandlerLib, then include the corresponding source file in each *CpuExceptionHandlerLib.inf? 

No, I mean extend the existing VmgExitLib instead of adding a new
VmTdExitLib, i.e. place the tdx handler in
OvmfPkg/Library/VmgExitLib/TdxExitHandler.c

take care,
  Gerd