From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web12.13125.1635347462833949043 for ; Wed, 27 Oct 2021 08:11:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=S18pfDF9; spf=pass (domain: nuviainc.com, ip: 209.85.221.49, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f49.google.com with SMTP id p14so4695984wrd.10 for ; Wed, 27 Oct 2021 08:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=i+5pYflI4lxF4TstBsp0mkgN1GfDe3+vGr+i3Zn4u98=; b=S18pfDF9XJMOrCuvqQtkPMwMdMQzcPt2zhHLQSE+sk+V67LChrJGasm/Mj3EV4QEIx /CofJDz9fagYZFyEW7MNKbJJBfOQIcJ3BUIfeoccqICKGq/D3m0HKk+uPvr9ZChOWLYS QMFE3OJS/GiL31W+es/uRwInnANrv5EcG0mA5nPnhHBSRmskplY9rwQmdPaNdu50P26Y mjAtdgpCmS0RzHIdWTD0f8p/cHfIaFWrNVz2RFjBRJ91c68ZD8Dng5j2V62rjw6azZSF uBqJcLdIFzHKyPyqFiULZu5pA1yuBIdmNWvcf1aActKiyDW5bfSkbLJoM76PTKNG9D4N EIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i+5pYflI4lxF4TstBsp0mkgN1GfDe3+vGr+i3Zn4u98=; b=GlaXJJfhI4RHcOhZOHBvcvc6U938EY83N+f2AaQoKIxyyQ4X6jhzeF06rM8JRwGF9y kBUcdcJt2sz37Q19Lbzs3JtAgGrc8yPOGNANsosxX1oR1O29pM1W1aiknZDTNhBjHYTM pk0q2orpgul93bzr3ne7kS3MKkFYoHs6lg10xX28bAoiJ8iIj9LzhvLkYIfozzzcEBPg wmH3QT76z/SHlIZdYQBZhOoC9SvWqvxTwPL7BLyxrdMCQ6Iso9MRfqAuTIdKN0pd45Yp 29wzewTlYCo34H5foxM0PuQJuusuTLO1grBpRdW4pCPutE7ijub2azC3dJ/SA25Bob0K TLxQ== X-Gm-Message-State: AOAM533zFpGmNV79OU3z7SKmBiW1TWVQ9xB4sO/iCS1GNIZJ8Uy/Q8Pf 12kcpoVsywlGE+J/1qU0F10B7g== X-Google-Smtp-Source: ABdhPJyOrQvfkxv86F3beGMUeIFgZlRMLNh6a3LQev1aZeXtdKOj9hGPvbFfLOu3DM+lfcn0vZpxRg== X-Received: by 2002:adf:f202:: with SMTP id p2mr3492046wro.93.1635347461356; Wed, 27 Oct 2021 08:11:01 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id p11sm4228080wmi.0.2021.10.27.08.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 08:11:01 -0700 (PDT) Date: Wed, 27 Oct 2021 16:10:59 +0100 From: "Leif Lindholm" To: Samer El-Haj-Mahmoud Cc: "devel@edk2.groups.io" , Masami Hiramatsu , Ard Biesheuvel , Kazuhiko Sakamoto Subject: Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Message-ID: <20211027151059.277p23dkeftzbcks@leviathan> References: <163410340292.323609.10978291802739074305.stgit@localhost> <20211027112133.d53azpi2qtktmfpg@leviathan> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline There is a case for that tag, but it is not this one. I'm not asking Masami to drop his S-o-b, and Sakamoto-san maintains their authorship (via the From: tag) - so both will be acknowledged in the end result. On Wed, Oct 27, 2021 at 13:55:56 +0000, Samer El-Haj-Mahmoud wrote: > For situations like this, maybe " Co-authored-by" can be used? > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Leif > > Lindholm via groups.io > > Sent: Wednesday, October 27, 2021 7:22 AM > > To: Masami Hiramatsu > > Cc: Ard Biesheuvel ; devel@edk2.groups.io; > > Kazuhiko Sakamoto > > Subject: Re: [edk2-devel] [PATCH 0/4] SynQuacer drivers test the > > ControllerHandle correctly > > > > Hi Masami, > > > > Apologies for delay. > > > > Thank you, this set looks good. > > However, you cannot make legal statements on behalf of Sakamoto-san, > > only yourself. If you are happy with that, I could drop their > > Signed-off-by: statements before I push. They would retain the > > authorship. > > > > Best Regards, > > > > Leif > > > > On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote: > > > Hello, > > > > > > Here are the patches to fix the SynQuacer related drivers to test > > > whether the ControllerHandle is managed by that driver correctly. > > > These bugs are found by edk2-test. > > > > > > Thank you, > > > > > > --- > > > > > > Kazuhiko Sakamoto (4): > > > Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by > > this driver > > > Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this > > driver > > > Silicon/AtSha204a: Test the ControllerHandle is managed by this driver > > > Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this > > driver > > > > > > > > > Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 + > > > Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++ > > > Silicon/Atmel/AtSha204a/DriverBinding.c | 1 - > > > Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 + > > > Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13 > > +++++++++++++ > > > Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 - > > > .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++ > > > .../Drivers/Net/NetsecDxe/DriverBinding.c | 1 - > > > .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 + > > > .../Drivers/SynQuacerI2cDxe/ComponentName.c | 13 > > +++++++++++++ > > > .../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +- > > > .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 + > > > 12 files changed, 57 insertions(+), 4 deletions(-) > > > > > > -- > > > Masami Hiramatsu > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.