* [PATCH] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers
@ 2021-10-28 1:07 Shashi Mallela
2021-11-01 17:37 ` Leif Lindholm
0 siblings, 1 reply; 2+ messages in thread
From: Shashi Mallela @ 2021-10-28 1:07 UTC (permalink / raw)
To: leif, ardb+tianocore, graeme; +Cc: devel, Ard Biesheuvel
Setting the Always-on Capability bit in GTDT table for
system PE timers in sbsa platform.This is also required
for ACS sbsa level 3 test compliancy.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
---
Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
index 14733a37183d..27db6da61704 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
@@ -28,8 +28,11 @@
#define GTDT_TIMER_LEVEL_TRIGGERED 0
#define GTDT_TIMER_ACTIVE_LOW EFI_ACPI_6_3_GTDT_TIMER_FLAG_TIMER_INTERRUPT_POLARITY
#define GTDT_TIMER_ACTIVE_HIGH 0
+#define GTDT_TIMER_ALWAYS_ON EFI_ACPI_6_3_GTDT_TIMER_FLAG_ALWAYS_ON_CAPABILITY
-#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED)
+#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW |
+ GTDT_TIMER_LEVEL_TRIGGERED |
+ GTDT_TIMER_ALWAYS_ON)
#define SBSA_PLATFORM_WATCHDOG_COUNT 1
#define SBSA_PLATFORM_TIMER_COUNT (SBSA_PLATFORM_WATCHDOG_COUNT)
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers
2021-10-28 1:07 [PATCH] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers Shashi Mallela
@ 2021-11-01 17:37 ` Leif Lindholm
0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2021-11-01 17:37 UTC (permalink / raw)
To: Shashi Mallela; +Cc: ardb+tianocore, graeme, devel, Ard Biesheuvel
Hi Shashi,
The build fails after applying this patch.
Please resubmit after you have fixed *and* tested it.
/
Leif
On Wed, Oct 27, 2021 at 21:07:56 -0400, Shashi Mallela wrote:
> Setting the Always-on Capability bit in GTDT table for
> system PE timers in sbsa platform.This is also required
> for ACS sbsa level 3 test compliancy.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> ---
> Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> index 14733a37183d..27db6da61704 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> @@ -28,8 +28,11 @@
> #define GTDT_TIMER_LEVEL_TRIGGERED 0
> #define GTDT_TIMER_ACTIVE_LOW EFI_ACPI_6_3_GTDT_TIMER_FLAG_TIMER_INTERRUPT_POLARITY
> #define GTDT_TIMER_ACTIVE_HIGH 0
> +#define GTDT_TIMER_ALWAYS_ON EFI_ACPI_6_3_GTDT_TIMER_FLAG_ALWAYS_ON_CAPABILITY
>
> -#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED)
> +#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW |
> + GTDT_TIMER_LEVEL_TRIGGERED |
> + GTDT_TIMER_ALWAYS_ON)
>
> #define SBSA_PLATFORM_WATCHDOG_COUNT 1
> #define SBSA_PLATFORM_TIMER_COUNT (SBSA_PLATFORM_WATCHDOG_COUNT)
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-01 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-28 1:07 [PATCH] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers Shashi Mallela
2021-11-01 17:37 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox