From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Sean Brogan <spbrogan@outlook.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH 1/6] OvmfPkg/PlatformCI: factor out PlatformBuildLib.py
Date: Fri, 29 Oct 2021 07:07:42 +0200 [thread overview]
Message-ID: <20211029050742.y3cko55pzd3lzoej@sirius.home.kraxel.org> (raw)
In-Reply-To: <BY3PR19MB490005FD6122CE9B9DB14D0EC8869@BY3PR19MB4900.namprd19.prod.outlook.com>
On Thu, Oct 28, 2021 at 10:09:07AM -0700, Sean Brogan wrote:
> one thing that jumped out quickly (comment below).
> Do you have a branch that i can look at and compare online?
https://github.com/kraxel/edk2/commits/ovmf-ci
> > +sys.path.append(os.path.join(os.getcwd(), 'OvmfPkg', 'PlatformCI'))
>
> I would strongly suggest you base your path off your current file location
> rather than CWD. This makes invocation much more flexible. See how
> workspace root is determined for similar solution.
Yep, that'll be more robust indeed.
take care,
Gerd
next prev parent reply other threads:[~2021-10-29 5:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 8:08 [PATCH 0/6] OvmfPkg/PlatformCI: hook up AmdSev, Bhyve and Microvm Gerd Hoffmann
2021-10-19 8:08 ` [PATCH 1/6] OvmfPkg/PlatformCI: factor out PlatformBuildLib.py Gerd Hoffmann
2021-10-28 17:09 ` [edk2-devel] " Sean
2021-10-29 5:07 ` Gerd Hoffmann [this message]
2021-10-19 8:08 ` [PATCH 2/6] OvmfPkg/PlatformCI: add QEMU_SKIP Gerd Hoffmann
2021-10-19 8:08 ` [PATCH 3/6] OvmfPkg/PlatformCI: add BhyveBuild.py Gerd Hoffmann
2021-10-19 8:08 ` [PATCH 4/6] OvmfPkg/PlatformCI: add MicrovmBuild.py Gerd Hoffmann
2021-10-19 8:08 ` [PATCH 5/6] OvmfPkg/PlatformCI: add AmdSevBuild.py Gerd Hoffmann
2021-10-19 8:08 ` [PATCH 6/6] OvmfPkg/PlatformCI: dummy grub.efi for AmdSev Gerd Hoffmann
2021-10-19 8:21 ` [PATCH 0/6] OvmfPkg/PlatformCI: hook up AmdSev, Bhyve and Microvm Yao, Jiewen
2021-10-19 8:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029050742.y3cko55pzd3lzoej@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox