From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.1489.1635484070342424107
 for <devel@edk2.groups.io>;
 Thu, 28 Oct 2021 22:07:50 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Dun4zzXF;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1635484069;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=4DVx+qkMWa4vsJB27IUvSrHn/28ra7WF0YZrm+mYW/o=;
	b=Dun4zzXFkFhLxsm4zdTgCbt9BZsuG7+B9w+4VxaM5azSm/C5oNzGlORK2dMTAzO1CN01JI
	sTVm/71feV2vWSry7YjP6H/TZTZ72V2PA0n2/HQs7mX6JYhrs/UHM/hRvPExKIH3VQFP/V
	Y1hJqv1G/xYXO5x5lTG3CwUvWAS/NbY=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-512-GdArxGuBNzWVg_yJt0wp6w-1; Fri, 29 Oct 2021 01:07:46 -0400
X-MC-Unique: GdArxGuBNzWVg_yJt0wp6w-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CCB96801B01;
	Fri, 29 Oct 2021 05:07:44 +0000 (UTC)
Received: from sirius.home.kraxel.org (ovpn-112-241.phx2.redhat.com [10.3.112.241])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 8136917CD9;
	Fri, 29 Oct 2021 05:07:44 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 8DA031800393; Fri, 29 Oct 2021 07:07:42 +0200 (CEST)
Date: Fri, 29 Oct 2021 07:07:42 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Sean Brogan <spbrogan@outlook.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH 1/6] OvmfPkg/PlatformCI: factor out PlatformBuildLib.py
Message-ID: <20211029050742.y3cko55pzd3lzoej@sirius.home.kraxel.org>
References: <20211019080832.265545-1-kraxel@redhat.com>
 <20211019080832.265545-2-kraxel@redhat.com>
 <BY3PR19MB490005FD6122CE9B9DB14D0EC8869@BY3PR19MB4900.namprd19.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <BY3PR19MB490005FD6122CE9B9DB14D0EC8869@BY3PR19MB4900.namprd19.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 28, 2021 at 10:09:07AM -0700, Sean Brogan wrote:
> one thing that jumped out quickly (comment below).
> Do you have a branch that i can look at and compare online?

https://github.com/kraxel/edk2/commits/ovmf-ci

> > +sys.path.append(os.path.join(os.getcwd(), 'OvmfPkg', 'PlatformCI'))
> 
> I would strongly suggest you base your path off your current file location
> rather than CWD.  This makes invocation much more flexible. See how
> workspace root is determined for similar solution.

Yep, that'll be more robust indeed.

take care,
  Gerd