public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 2/2] OvmfPkg: Switch timer in build time for OvmfPkg
Date: Fri, 29 Oct 2021 13:37:25 +0200	[thread overview]
Message-ID: <20211029113725.clpwhdqejongir7h@sirius.home.kraxel.org> (raw)
In-Reply-To: <eb96300e187393268546b8b57be0bff464edfa98.1635489019.git.min.m.xu@intel.com>

> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
> @@ -670,10 +670,9 @@
>    }
>  
>    MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> -  OvmfPkg/8259InterruptControllerDxe/8259.inf
>    UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
>    UefiCpuPkg/CpuDxe/CpuDxe.inf
> -  OvmfPkg/8254TimerDxe/8254Timer.inf
> +  OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf
>    OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf
>    OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
>    MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {

Also needs "gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000"

(same for the other OvmfPkg files).

> --- a/OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.c
> +++ b/OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.c
> @@ -173,7 +173,7 @@ TimerDriverSetTimerPeriod (
>      //
>      DisableApicTimerInterrupt();
>    } else {
> -    TimerFrequency = PcdGet32(PcdFSBClock) / DivideValue;
> +    TimerFrequency = PcdGet32(PcdFSBClock) / (UINT32)DivideValue;

Why is this cast needed?

take care,
  Gerd


  reply	other threads:[~2021-10-29 11:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29  6:50 [PATCH 0/2] Rename XenTimerDxe to LocalApicTimerDxe Min Xu
2021-10-29  6:50 ` [PATCH 1/2] OvmfPkg: " Min Xu
2021-10-29  6:50 ` [PATCH 2/2] OvmfPkg: Switch timer in build time for OvmfPkg Min Xu
2021-10-29 11:37   ` Gerd Hoffmann [this message]
2021-10-30  7:24     ` [edk2-devel] " Min Xu
2021-10-29  9:19 ` [PATCH 0/2] Rename XenTimerDxe to LocalApicTimerDxe Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211029113725.clpwhdqejongir7h@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox