From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.4181.1635507650838058937 for ; Fri, 29 Oct 2021 04:40:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R96mT8fe; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635507650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hDRbl7rbKNa2H2Q4e7IeQayvwnOsPihphZssGk/1tak=; b=R96mT8feeOGOfLFmoTem9cK2xvZYtGavsHuEmBALS3BVBeR++6ttgY5AeYf5vq+zp7FK6E j6B0n5jQa6glWyRI00/BTDNIdL4IOJTaYBWYsvZtPvlLmYCdHFOs76TCvOAPoVoeiCrHu+ C9fVxj6ohrMFe0WQYRxzhDPi1MEYuBk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-nbtbyXVyNEeFAgfUWq0BUw-1; Fri, 29 Oct 2021 07:40:46 -0400 X-MC-Unique: nbtbyXVyNEeFAgfUWq0BUw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD3D918125C0; Fri, 29 Oct 2021 11:40:44 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-241.phx2.redhat.com [10.3.112.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D14E19D9B; Fri, 29 Oct 2021 11:40:44 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9F6DD1801F1D; Fri, 29 Oct 2021 13:40:42 +0200 (CEST) Date: Fri, 29 Oct 2021 13:40:42 +0200 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , "Yao, Jiewen" , Tom Lendacky , Brijesh Singh , "sami.mujawar@arm.com" , Erdem Aktas , James Bottomley , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception Message-ID: <20211029114042.bra7yattgt5c73lk@sirius.home.kraxel.org> References: <20211026102458.pvzp5nxyegq7ftuu@sirius.home.kraxel.org> <20211027071935.a4l3aiiu6uaaqdvl@sirius.home.kraxel.org> <20211029045249.73cvvuhuh7q7dzum@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 29, 2021 at 07:51:13AM +0000, Xu, Min M wrote: > On October 29, 2021 12:53 PM, Gerd Hoffmann wrote: > > On Fri, Oct 29, 2021 at 12:17:05AM +0000, Yao, Jiewen wrote: > > > I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace > > > EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO) > > > > Looks good to me. The PCD uses the term ConfidentialComputing too, so using > > that or 'CC' as shortcut consistently everywhere makes sense. > > > So do we reach consensus that as the first step, extend the existing > VmgExitLib to place the tdx handler > (OvmfPkg/Library/VmgExitLib/TdxExitHandler.c). After SNP patch is > merged, rename VmgExitLib to CcExitLib. Right? snp series goes first. Whenever adding TdxExitHandler.c or renaming the library goes next doesn't matter much, just do whatever is easier for you. The renaming can be a separate series, so maybe easiest to do that first and merge quickly so you have less unmerged patches to handle. take care, Gerd