From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.web12.47143.1635786984830901344 for ; Mon, 01 Nov 2021 10:16:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=s605hEO2; spf=pass (domain: nuviainc.com, ip: 209.85.221.53, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f53.google.com with SMTP id v17so29089302wrv.9 for ; Mon, 01 Nov 2021 10:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=DQ1lRYQCMxYrmAacJjvOA5PnwZiXFgkpApOkAX7DqRc=; b=s605hEO2lyJ6rAn+wIKIlO0u2B+2w2p8tx9YGBJMMSXcFwTwRePoNe0L/tWnulEnJs Pa2q2dCmqlGv0ouxRHaYoZy/NFIy6qAPkSUHboryKZ9TMZy4vQVz1uPVRfbA7SfSVv1C 9kYd9fc9gc3MCwfkUV4f/HDv3/upbUN+t4DrbS1ceF/EDkj8LWViQJfspqfSnWtN0vQd yCCoqM79/rJMb9svBtnK0gmFX1S/dqAtu23f5Zwo+GCvgqB3SZLqcUoe8p3med1GJ4aV TriCGwdTCUSA5S60RX2HskCcRVMJRTO1C84wD76p4N1YY8VftE4rO7Y4hELZM12/YQdz ANFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=DQ1lRYQCMxYrmAacJjvOA5PnwZiXFgkpApOkAX7DqRc=; b=PgnXu+m9NAFrsvSMflDSHmE8I3CNq1fXo072LNg7hPN6KrpWAHf1C6Juvl8tlU8Iys 8860ElV7mfGxqDggCtzOceB8zHQQwUuJBYrhFEGg2Bv5ZUTmjZeFWAWeZIPOxK3kb59I 2uMBAeabvySuTd1SMTvQhUZbUhDlw+XwdPDgSTVwwlL6kX9RH8xTe7/7zghyU1jHZFUY pqoFrNT1Kup/e6V07xSvbPeT5B4rvbWb6Agik0LvKgidnq/6NgejDuj95NDNucS5atnY zNc9yegfp4M/JjQqkwfIMyWv4a4QeYEp64wpYfI9qlGDKHyqHbsgubrGgOl2VQ1+m+jJ +IjQ== X-Gm-Message-State: AOAM533eUt94qpuXjbCZhcoIwREfyvin45iGSX2/Hs40CTLZX9VxrLIh 1xL2z92j42C9cyZh6NFtQFFxsA== X-Google-Smtp-Source: ABdhPJysvkS4xfJiJElcJGbJb089KwmTzLFOorLhat5Zlv03mCRSqKed4Tfv1L6agP2hscp1NaFxWA== X-Received: by 2002:a5d:4a0a:: with SMTP id m10mr13750937wrq.221.1635786983344; Mon, 01 Nov 2021 10:16:23 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id l2sm491455wmi.1.2021.11.01.10.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 10:16:22 -0700 (PDT) Date: Mon, 1 Nov 2021 17:16:21 +0000 From: "Leif Lindholm" To: Masami Hiramatsu Cc: Ard Biesheuvel , devel@edk2.groups.io, Kazuhiko Sakamoto Subject: Re: [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Message-ID: <20211101171621.v335j2pp2lnperzt@leviathan> References: <163410340292.323609.10978291802739074305.stgit@localhost> <20211027112133.d53azpi2qtktmfpg@leviathan> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Oct 28, 2021 at 09:53:34 +0900, Masami Hiramatsu wrote: > Hi Leif, > > Thank you for your reply! > > 2021年10月27日(水) 20:21 Leif Lindholm : > > > > Hi Masami, > > > > Apologies for delay. > > > > Thank you, this set looks good. > > However, you cannot make legal statements on behalf of Sakamoto-san, > > only yourself. If you are happy with that, I could drop their > > Signed-off-by: statements before I push. They would retain the > > authorship. > > Actually I got this patch from Sakamoto-san with the Signed-off-by, so I sent > it via my own internal tree. OK, next time I will ask Sakamoto-san to send it > by himself, or just report to me and I write the patch. > > Thank you, For the series: Reviewed-by: Leif Lindholm Pushed as 06489b36ab34..a4f52afa363c. (I also dropped the Contributed-under: tags - we stopped using those after the license transition to bsd+patent.) Best Regards, Leif > > > > Best Regards, > > > > Leif > > > > On Wed, Oct 13, 2021 at 14:36:43 +0900, Masami Hiramatsu wrote: > > > Hello, > > > > > > Here are the patches to fix the SynQuacer related drivers to test > > > whether the ControllerHandle is managed by that driver correctly. > > > These bugs are found by edk2-test. > > > > > > Thank you, > > > > > > --- > > > > > > Kazuhiko Sakamoto (4): > > > Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver > > > Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver > > > Silicon/AtSha204a: Test the ControllerHandle is managed by this driver > > > Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver > > > > > > > > > Silicon/Atmel/AtSha204a/AtSha204aDriver.h | 1 + > > > Silicon/Atmel/AtSha204a/ComponentName.c | 13 +++++++++++++ > > > Silicon/Atmel/AtSha204a/DriverBinding.c | 1 - > > > Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h | 1 + > > > Silicon/Openmoko/ChaosKeyDxe/ComponentName.c | 13 +++++++++++++ > > > Silicon/Openmoko/ChaosKeyDxe/DriverBinding.c | 1 - > > > .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++ > > > .../Drivers/Net/NetsecDxe/DriverBinding.c | 1 - > > > .../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 + > > > .../Drivers/SynQuacerI2cDxe/ComponentName.c | 13 +++++++++++++ > > > .../Drivers/SynQuacerI2cDxe/DriverBinding.c | 2 +- > > > .../Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.h | 1 + > > > 12 files changed, 57 insertions(+), 4 deletions(-) > > > > > > -- > > > Masami Hiramatsu > > > > -- > Masami Hiramatsu