public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Shashi Mallela <shashi.mallela@linaro.org>
Cc: ardb+tianocore@kernel.org, graeme@nuviainc.com,
	devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [PATCH] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers
Date: Mon, 1 Nov 2021 17:37:00 +0000	[thread overview]
Message-ID: <20211101173700.ukcogcmn4lfozm23@leviathan> (raw)
In-Reply-To: <20211028010756.27425-1-shashi.mallela@linaro.org>

Hi Shashi,

The build fails after applying this patch.
Please resubmit after you have fixed *and* tested it.

/
    Leif

On Wed, Oct 27, 2021 at 21:07:56 -0400, Shashi Mallela wrote:
> Setting the Always-on Capability bit in GTDT table for
> system PE timers in sbsa platform.This is also required
> for ACS sbsa level 3 test compliancy.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> ---
>  Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> index 14733a37183d..27db6da61704 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> @@ -28,8 +28,11 @@
>  #define GTDT_TIMER_LEVEL_TRIGGERED  0
>  #define GTDT_TIMER_ACTIVE_LOW       EFI_ACPI_6_3_GTDT_TIMER_FLAG_TIMER_INTERRUPT_POLARITY
>  #define GTDT_TIMER_ACTIVE_HIGH      0
> +#define GTDT_TIMER_ALWAYS_ON        EFI_ACPI_6_3_GTDT_TIMER_FLAG_ALWAYS_ON_CAPABILITY
>  
> -#define GTDT_GTIMER_FLAGS           (GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED)
> +#define GTDT_GTIMER_FLAGS           (GTDT_TIMER_ACTIVE_LOW |
> +                                     GTDT_TIMER_LEVEL_TRIGGERED |
> +                                     GTDT_TIMER_ALWAYS_ON)
>  
>  #define SBSA_PLATFORM_WATCHDOG_COUNT    1
>  #define SBSA_PLATFORM_TIMER_COUNT       (SBSA_PLATFORM_WATCHDOG_COUNT)
> -- 
> 2.27.0
> 

      reply	other threads:[~2021-11-01 17:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  1:07 [PATCH] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers Shashi Mallela
2021-11-01 17:37 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211101173700.ukcogcmn4lfozm23@leviathan \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox