From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web10.437.1635792185980536209 for ; Mon, 01 Nov 2021 11:43:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=aN30oFob; spf=pass (domain: nuviainc.com, ip: 209.85.128.44, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f44.google.com with SMTP id b184-20020a1c1bc1000000b0033140bf8dd5so545667wmb.5 for ; Mon, 01 Nov 2021 11:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QBxTfG8F6JNCIz/XfTQDAS6hZTxsx6fnSkO39zPft8g=; b=aN30oFobfI+WOlOy8TqKorO2nnDUCs7HK9HAfFO0U5fOmYMKBogA3CnJ7a8HE/c+lE YZN5hDt7A9+M+07HBEjim8NiFav4LDjgrUn7VrGRsmZ/Ix6wuUCiimV/jRPM5+j+xyR/ dGp5k1ErAYv2YWkW9u0buOicHhSyZzb5iUikVlj5u3b4SuwT4Wrgxl+rgAdDBKre5owB K3cBGROgid1nyiIaZsueCU5pUphNMH15V9XlYs/tkyD9zU9vuyAPxGKcNzrLl1ntIJ0B vpwJksgczk8fRh+KwB7irZyFSOO+0d5jQ1MAlHeINv7BJDkgjKSAennyLspIlf+Vk7Im U2CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QBxTfG8F6JNCIz/XfTQDAS6hZTxsx6fnSkO39zPft8g=; b=qgYyvki7Sroyb3IrKV5+k/UjSC8hQTz0KkmtsLlBTyjpGjyh0FQKahb9APLICzDaIF FC1i/AkfkNssyG15uKWGtvVoHYHLAYQEhhtViHH0kUv8viaO/T6ViJFwtNQmEaULnbxK U6AUopBarqLDY8eQEx1os+UMikrvkmUApK1l7jkIQfZGRJT/oXRfuxO9V7KrtJJbKA2M FIKTYDt+QoDE9A5VixYMT9pDUFmzNV1Tlx5je+WEsIa2/7sXPz4jjCfKc2rco0j23bLe E+6Y3WuXqXP3/B7SWCvdA2EEkV8knQAfpUxB3VPf1IPHgbm0cvF/sXCFYJ/ThUgvw2cy LsQQ== X-Gm-Message-State: AOAM533SZmYa5Pp8t3VBUlpPwJ1IZ52lLaEyYsOldj685oPikNdLjXu4 uSnP346p8Y1VJVa4C97yRugtMA== X-Google-Smtp-Source: ABdhPJwNJyhgZfZYFE/r9zvX62zNH7DIejTjUZqHVbJ6pJOozYtE1IgWM/qU/Ts4kmT2ZBc/ES0AMg== X-Received: by 2002:a05:600c:a49:: with SMTP id c9mr786742wmq.172.1635792184370; Mon, 01 Nov 2021 11:43:04 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id n25sm355328wms.10.2021.11.01.11.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 11:43:03 -0700 (PDT) Date: Mon, 1 Nov 2021 18:43:02 +0000 From: "Leif Lindholm" To: Marcin Juszkiewicz Cc: devel@edk2.groups.io, Shashi Mallela , Ard Biesheuvel , Graeme Gregory Subject: Re: [PATCH v2 1/1] Silicon/Qemu/Sbsa: Enable Always-On capability for PE timers Message-ID: <20211101184302.vfcd5kaxozmsxz7w@leviathan> References: <20211101175457.891151-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20211101175457.891151-1-marcin.juszkiewicz@linaro.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 01, 2021 at 18:54:57 +0100, Marcin Juszkiewicz wrote: > From: Shashi Mallela > > Setting the Always-on Capability bit in GTDT table for > system PE timers in sbsa platform.This is also required > for ACS sbsa level 3 test compliancy. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Graeme Gregory > Signed-off-by: Shashi Mallela > > [fixed compilation error] > > Signed-off-by: Marcin Juszkiewicz > Tested-by: Marcin Juszkiewicz Acked-by: Leif Lindholm Pushed as f5fe24c4efea - thanks! > --- > Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc > index 14733a37183d..ba145aff6413 100644 > --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc > +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc > @@ -28,8 +28,11 @@ > #define GTDT_TIMER_LEVEL_TRIGGERED 0 > #define GTDT_TIMER_ACTIVE_LOW EFI_ACPI_6_3_GTDT_TIMER_FLAG_TIMER_INTERRUPT_POLARITY > #define GTDT_TIMER_ACTIVE_HIGH 0 > +#define GTDT_TIMER_ALWAYS_ON EFI_ACPI_6_3_GTDT_TIMER_FLAG_ALWAYS_ON_CAPABILITY > > -#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED) > +#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW | \ > + GTDT_TIMER_LEVEL_TRIGGERED | \ > + GTDT_TIMER_ALWAYS_ON) > > #define SBSA_PLATFORM_WATCHDOG_COUNT 1 > #define SBSA_PLATFORM_TIMER_COUNT (SBSA_PLATFORM_WATCHDOG_COUNT) > -- > 2.32.0 >