From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [Patch 2/6] ArmPkg: Reproduce builds across source format changes
Date: Mon, 1 Nov 2021 18:53:18 +0000 [thread overview]
Message-ID: <20211101185318.dsibibbdwcfcrhxn@leviathan> (raw)
In-Reply-To: <20211101182942.321-3-michael.d.kinney@intel.com>
On Mon, Nov 01, 2021 at 11:29:38 -0700, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> Use DEBUG_LINE_NUMBER instead of __LINE__.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> .../Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
> .../Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 2 +-
> .../SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 2 +-
> .../SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 2 +-
> .../SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 2 +-
> .../Type13/MiscNumberOfInstallableLanguagesFunction.c | 2 +-
> .../Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> index 4b409ff7458c..cbdf6df01ee0 100644
> --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> @@ -689,7 +689,7 @@ AddSmbiosProcessorTypeTable (
>
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type04 Table Log Failed! %r \n",
> - __FUNCTION__, __LINE__, Status));
> + __FUNCTION__, DEBUG_LINE_NUMBER, Status));
> }
> FreePool (Type4Record);
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> index 5679ebaac8a5..2506c03d64b1 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
> @@ -271,7 +271,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor)
> Status = SmbiosMiscAddRecord ((UINT8*)SmbiosRecord, NULL);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type00 Table Log Failed! %r \n",
> - __FUNCTION__, __LINE__, Status));
> + __FUNCTION__, DEBUG_LINE_NUMBER, Status));
> }
>
> FreePool (SmbiosRecord);
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
> index 2c69c2593f5d..555557a2a946 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
> @@ -162,7 +162,7 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscSystemManufacturer)
> Status = SmbiosMiscAddRecord ((UINT8*)SmbiosRecord, NULL);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type01 Table Log Failed! %r \n",
> - __FUNCTION__, __LINE__, Status));
> + __FUNCTION__, DEBUG_LINE_NUMBER, Status));
> }
>
> FreePool (SmbiosRecord);
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> index 097777a23904..f11295b199b3 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
> @@ -196,7 +196,7 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscBaseBoardManufacturer)
> Status = SmbiosMiscAddRecord ((UINT8 *)SmbiosRecord, NULL);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type02 Table Log Failed! %r \n",
> - __FUNCTION__, __LINE__, Status));
> + __FUNCTION__, DEBUG_LINE_NUMBER, Status));
> }
>
> FreePool (SmbiosRecord);
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
> index 66e3e5327fc3..d64046182b96 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
> @@ -178,7 +178,7 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscChassisManufacturer)
> Status = SmbiosMiscAddRecord ((UINT8*)SmbiosRecord, NULL);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type03 Table Log Failed! %r \n",
> - __FUNCTION__, __LINE__, Status));
> + __FUNCTION__, DEBUG_LINE_NUMBER, Status));
> }
>
> FreePool (SmbiosRecord);
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
> index 7c941b5c0709..017b410a16d0 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
> @@ -158,7 +158,7 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscNumberOfInstallableLanguages)
> Status = SmbiosMiscAddRecord ((UINT8*)SmbiosRecord, NULL);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type13 Table Log Failed! %r \n",
> - __FUNCTION__, __LINE__, Status));
> + __FUNCTION__, DEBUG_LINE_NUMBER, Status));
> }
>
> FreePool (SmbiosRecord);
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c
> index 4be1e1cd29a9..c4ce6a5e7608 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c
> @@ -68,7 +68,7 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscBootInformation)
> Status = SmbiosMiscAddRecord ((UINT8*)SmbiosRecord, NULL);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type32 Table Log Failed! %r \n",
> - __FUNCTION__, __LINE__, Status));
> + __FUNCTION__, DEBUG_LINE_NUMBER, Status));
> }
>
> FreePool (SmbiosRecord);
> --
> 2.32.0.windows.1
>
>
>
>
>
>
next prev parent reply other threads:[~2021-11-01 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 18:29 [Patch 0/6] Reproduce builds across source format changes Michael D Kinney
2021-11-01 18:29 ` [Patch 1/6] MdePkg: " Michael D Kinney
2021-11-01 18:52 ` [edk2-devel] " Leif Lindholm
2021-11-01 18:29 ` [Patch 2/6] ArmPkg: " Michael D Kinney
2021-11-01 18:53 ` Leif Lindholm [this message]
2021-11-01 18:29 ` [Patch 3/6] MdeModulePkg: " Michael D Kinney
2021-11-01 18:29 ` [Patch 4/6] NetworkPkg: " Michael D Kinney
2021-11-01 18:29 ` [Patch 5/6] SecurityPkg: " Michael D Kinney
2021-11-01 18:29 ` [Patch 6/6] OvmfPkg: " Michael D Kinney
2021-11-01 19:03 ` [edk2-devel] [Patch 0/6] " Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101185318.dsibibbdwcfcrhxn@leviathan \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox