public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: "brbarkel@microsoft.com" <bret@corthon.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM
Date: Tue, 2 Nov 2021 08:43:13 +0000	[thread overview]
Message-ID: <20211102084313.scwv3uycao44o4l7@leviathan> (raw)
In-Reply-To: <20211101195648.6420-2-brbarkel@microsoft.com>

Hi Bret,

Is there some overall scope this set is aiming towards, or are these
16 unrelated patches to ArmPkg? Could you send out a cover-letter
separately to clarify?

Best Regards,

Leif

On Mon, Nov 01, 2021 at 12:56:33 -0700, brbarkel@microsoft.com wrote:
> From: Bret Barkelew <brbarkel@microsoft.com>
> 
> Not sure what all module types this HAS been validated against, but it
> doesn't work with STANDALONE_MM or STANDALONE_MM_CORE.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> ---
>  ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> index 2a7e7147958c..d0988b27d582 100644
> --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> @@ -13,7 +13,7 @@ [Defines]
>    FILE_GUID                      = da8f0232-fb14-42f0-922c-63104d2c70bd
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = ArmMmuLib
> +  LIBRARY_CLASS                  = ArmMmuLib | DXE_DRIVER PEIM PEI_CORE DXE_CORE DXE_RUNTIME_DRIVER SEC
>  
>  [Defines.AARCH64]
>    CONSTRUCTOR                    = ArmMmuBaseLibConstructor
> -- 
> 2.31.1.windows.1
> 

  reply	other threads:[~2021-11-02  8:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 19:56 [PATCH v1 00/16] Un-siloing Arm common code Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM Bret Barkelew
2021-11-02  8:43   ` Leif Lindholm [this message]
2021-11-02  8:50     ` [edk2-devel] " ryan.harkin
2021-11-02  9:03       ` Leif Lindholm
2021-11-02  9:26   ` Leif Lindholm
2021-11-01 19:56 ` [PATCH v1 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib Bret Barkelew
2021-11-02  9:34   ` Leif Lindholm
2021-11-02  9:39     ` Leif Lindholm
2021-11-01 19:56 ` [PATCH v1 03/16] ArmPkg/StandaloneMmCoreEntryPoint: Swap to ArmMmuLib Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib Bret Barkelew
2021-11-02  9:39   ` Leif Lindholm
2021-11-01 19:56 ` [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg Bret Barkelew
2021-11-02  9:50   ` Leif Lindholm
2021-11-02 19:44     ` [EXTERNAL] Re: [edk2-devel] " Bret Barkelew
2021-11-04  6:23     ` 回复: " gaoliming
2021-11-04  6:24       ` Andrew Fish
2021-11-04 17:23         ` Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools Bret Barkelew
2021-11-02  9:55   ` Leif Lindholm
2021-11-02 19:45     ` [EXTERNAL] Re: [edk2-devel] " Bret Barkelew
2021-11-02 23:34       ` [EXTERNAL] " Andrew Fish
2021-11-03 11:03         ` Leif Lindholm
2021-11-03 15:35         ` Bob Feng
2021-11-03 16:08           ` Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg Bret Barkelew
2021-11-02  1:52   ` 回复: " gaoliming
2021-11-02  9:24   ` Leif Lindholm
2021-11-02 19:48     ` Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 08/16] MdePkg: Create the MMU access lib to abstract memory protection settings Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 09/16] MdeModulePkg: Swap to MmuLib instead of Arm-specific lib Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 10/16] StandaloneMmPkg: Switch to the MmuLib abstraction Bret Barkelew
2021-11-02  0:25   ` [edk2-devel] " Yao, Jiewen
2021-11-01 19:56 ` [PATCH v1 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon Bret Barkelew
2021-11-02  9:57   ` Leif Lindholm
2021-11-02 19:51     ` Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg Bret Barkelew
2021-11-02 10:00   ` Leif Lindholm
2021-11-02 19:53     ` Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib " Bret Barkelew
2021-11-02 10:00   ` Leif Lindholm
2021-11-01 19:56 ` [PATCH v1 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only Bret Barkelew
2021-11-02 10:05   ` Leif Lindholm
2021-11-01 19:56 ` [PATCH v1 15/16] ArmPkg/ArmPkg.dsc: Resolve build errors resulting from package moves Bret Barkelew
2021-11-01 19:56 ` [PATCH v1 16/16] ArmPlatformPkg/ArmPlatformPkg.dsc: " Bret Barkelew
2021-11-02  0:26 ` [edk2-devel] [PATCH v1 00/16] Un-siloing Arm common code Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211102084313.scwv3uycao44o4l7@leviathan \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox