Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

["Leif Lindholm" <leif@nuviainc.com>]

On Tue, Nov 02, 2021 at 08:50:05 +0000, Ryan Harkin wrote:
> Hi Leif,
> 
> There's a 00/16 in the series with a brief explanation that I'll paste here:

Ah, I see.
I was cc:d on all the patches, but no one was cc:d on the
cover-letter. Thanks for forwarding!

Probably still for the best if Bret resubmits the cover letter with
all the affected maintainers on cc.

> "This series of patch commits moves a number of modules and libraries around in order
> to better un-silo the Arm-specific code. Unnecessary abstractions were removed, some
> duplicate code was abstracted, and generally things were cleaned up so that common
> code (e.g. MdePkg, MdeModulePkg, StandaloneMmPkg) does not require ArmPkg or
> ArmPlatformPkg.
> 
> Also, some things that were previously hidden away under ArmPkg are now located
> with the core functionality or build tooling that makes sense for it."
> 
> Cheers,
> Ryan
> 
> ________________________________
> From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Leif Lindholm via groups.io <leif=nuviainc.com@groups.io>
> Sent: 02 November 2021 08:43
> To: brbarkel@microsoft.com <bret@corthon.com>
> Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sean Brogan <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM
> 
> Hi Bret,
> 
> Is there some overall scope this set is aiming towards, or are these
> 16 unrelated patches to ArmPkg? Could you send out a cover-letter
> separately to clarify?
> 
> Best Regards,
> 
> Leif
> 
> On Mon, Nov 01, 2021 at 12:56:33 -0700, brbarkel@microsoft.com wrote:
> > From: Bret Barkelew <brbarkel@microsoft.com>
> >
> > Not sure what all module types this HAS been validated against, but it
> > doesn't work with STANDALONE_MM or STANDALONE_MM_CORE.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> > ---
> >  ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> > index 2a7e7147958c..d0988b27d582 100644
> > --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> > +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> > @@ -13,7 +13,7 @@ [Defines]
> >    FILE_GUID                      = da8f0232-fb14-42f0-922c-63104d2c70bd
> >    MODULE_TYPE                    = BASE
> >    VERSION_STRING                 = 1.0
> > -  LIBRARY_CLASS                  = ArmMmuLib
> > +  LIBRARY_CLASS                  = ArmMmuLib | DXE_DRIVER PEIM PEI_CORE DXE_CORE DXE_RUNTIME_DRIVER SEC
> >
> >  [Defines.AARCH64]
> >    CONSTRUCTOR                    = ArmMmuBaseLibConstructor
> > --
> > 2.31.1.windows.1
> >
> 
> 
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.