From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web12.6724.1635843795150971993 for ; Tue, 02 Nov 2021 02:03:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=qs+eDjeX; spf=pass (domain: nuviainc.com, ip: 209.85.221.49, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f49.google.com with SMTP id d13so32101768wrf.11 for ; Tue, 02 Nov 2021 02:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=T6jHq9dMCx+1kuro7sjFDtSRmLxiyveKJfoENFBRcOc=; b=qs+eDjeXiXyi7LPnHTh59iZoPtl8qiT2d4/Kl35kJsZmZ4HSBT5HbzUvhRnmXYtq18 BVGKZCpeipN4XRb99vUa9ukJB3bGODMV7f1dTJojuxr18ALilz2N7KQV78jfDdOYNRfC eHkJA0c698HWY6KuLfsStuUckrm8SOkba2AFL7KQV/6D0NpmRH+/C43ZTkY4uF5DlSBq 7V6PV8U+dRYJIF6OsHPt4kTKBTAyCjhe3WpNh0Wr8dJ1jdPELku6oHmA+qSkmJcxdOAa 08kPqsGKb/RqGFJeXvFyjUxhWf+nRV+hquKNiNv37jWOBo+LQgLYFkxEWJTFwZtOW18a OKsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T6jHq9dMCx+1kuro7sjFDtSRmLxiyveKJfoENFBRcOc=; b=KTiN/ado9T7CJSDzyKiCTVe7//+Kc3C5N3Ou6m4x3KRLcdlzdxGH/8ictss0nYlt4r /aMa4JVXZHteUHWSoskarDSK/iTHvkFq6bpkq9nbgvddFYCz29kVYgX21akQfZckSGkC kEmeqTijshLyLmp9VFhPp/UvBdVttEaUkf+twkwrdeqeM+TI9DOkksQVULW3cPLkPNl4 QC0nwVEahVNyDEE4ixT3YJZY3ImlqVx0c5pW8REqKLCaOw28i6hs66x5xAuKiXxEyCaZ 153VAtCcb6H1xvPutFfXxipD1n65kgh4fQKm4tJldzxK45OcqdHBa3tg1aNznwclG5H4 BfSg== X-Gm-Message-State: AOAM532YmK9UV6wqE5jhlyhitM72BOW+J+a/NjO5JoirGS1EwMcC19bc V3usbjvVNQJTU9QHws9WtkGH3w== X-Google-Smtp-Source: ABdhPJwtWBFhlFSuXWq8tkgAD0YfIpJthpUKuV/Er0dbFvF5Dz3qN/hGr0gYF5pcVvSLwEmT1u6uPg== X-Received: by 2002:a05:6000:1869:: with SMTP id d9mr10103506wri.416.1635843793357; Tue, 02 Nov 2021 02:03:13 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id m15sm1824656wmq.0.2021.11.02.02.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 02:03:13 -0700 (PDT) Date: Tue, 2 Nov 2021 09:03:11 +0000 From: "Leif Lindholm" To: Ryan Harkin Cc: "brbarkel@microsoft.com" , "devel@edk2.groups.io" , Ard Biesheuvel , Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM Message-ID: <20211102090311.o5wm6kgjavtkhege@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-2-brbarkel@microsoft.com> <20211102084313.scwv3uycao44o4l7@leviathan> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 02, 2021 at 08:50:05 +0000, Ryan Harkin wrote: > Hi Leif, > > There's a 00/16 in the series with a brief explanation that I'll paste here: Ah, I see. I was cc:d on all the patches, but no one was cc:d on the cover-letter. Thanks for forwarding! Probably still for the best if Bret resubmits the cover letter with all the affected maintainers on cc. > "This series of patch commits moves a number of modules and libraries around in order > to better un-silo the Arm-specific code. Unnecessary abstractions were removed, some > duplicate code was abstracted, and generally things were cleaned up so that common > code (e.g. MdePkg, MdeModulePkg, StandaloneMmPkg) does not require ArmPkg or > ArmPlatformPkg. > > Also, some things that were previously hidden away under ArmPkg are now located > with the core functionality or build tooling that makes sense for it." > > Cheers, > Ryan > > ________________________________ > From: devel@edk2.groups.io on behalf of Leif Lindholm via groups.io > Sent: 02 November 2021 08:43 > To: brbarkel@microsoft.com > Cc: devel@edk2.groups.io ; Ard Biesheuvel ; Sean Brogan > Subject: Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM > > Hi Bret, > > Is there some overall scope this set is aiming towards, or are these > 16 unrelated patches to ArmPkg? Could you send out a cover-letter > separately to clarify? > > Best Regards, > > Leif > > On Mon, Nov 01, 2021 at 12:56:33 -0700, brbarkel@microsoft.com wrote: > > From: Bret Barkelew > > > > Not sure what all module types this HAS been validated against, but it > > doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sean Brogan > > Signed-off-by: Bret Barkelew > > --- > > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > > index 2a7e7147958c..d0988b27d582 100644 > > --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > > +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > > @@ -13,7 +13,7 @@ [Defines] > > FILE_GUID = da8f0232-fb14-42f0-922c-63104d2c70bd > > MODULE_TYPE = BASE > > VERSION_STRING = 1.0 > > - LIBRARY_CLASS = ArmMmuLib > > + LIBRARY_CLASS = ArmMmuLib | DXE_DRIVER PEIM PEI_CORE DXE_CORE DXE_RUNTIME_DRIVER SEC > > > > [Defines.AARCH64] > > CONSTRUCTOR = ArmMmuBaseLibConstructor > > -- > > 2.31.1.windows.1 > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.