From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49])
 by mx.groups.io with SMTP id smtpd.web08.6850.1635845102811218456
 for <devel@edk2.groups.io>;
 Tue, 02 Nov 2021 02:25:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=tVH/KjsP;
 spf=pass (domain: nuviainc.com, ip: 209.85.128.49, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f49.google.com with SMTP id o4-20020a1c7504000000b0032cab7473caso1166541wmc.1
        for <devel@edk2.groups.io>; Tue, 02 Nov 2021 02:25:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20210112.gappssmtp.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=Z+8MZjv88Pb4yxTPVsJWRfnw4lrv0AWyzACzuEPhDpc=;
        b=tVH/KjsPV6pIo5D7gl3ZKt7ZuPur+ZGTn/IxODLpOk3QAv13nPs6UZJ88rnneRzCTV
         Tv/FpZwbTZi3cQ0FcERIwXlBkvBUnJXvPutzsGKwNDMt8bycKsBestpM/HmwU7XG2Lh3
         Z6Rpa/0LNnrcokZb0+bmKnvl79xRABanxS5n5410Tsa9oktpy3K3C7QxPs/683l4KGdu
         XFriRrLeNOoNziv2CpqdsSUkizxzxfVovidXUmx1n3PM1t91L90sMLejWI8NEAAMEtxj
         3XsooM704x4ehvLCj8Vp+jeiEc1PsXzbX5uo+NPszC4jbQNiT8HZaYBfvVSTb50Gbut/
         zFlA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=Z+8MZjv88Pb4yxTPVsJWRfnw4lrv0AWyzACzuEPhDpc=;
        b=cKEvXG3wv+cORSG429bo9fLKGUfA+nuphGAV4veQDoY1XqOc8+GzXz4lz3V0/IjY7R
         rlmovqdJOz0db6G7MiTbx4kfmAPxD0+9/Byxc4lxdJV4MSSbE9W9EYQAkBZ0IdRBRDfc
         ELiaZgjlSm/BXmWEywGRcaKCje2NZOTy1yQPq9pqc79a3KoqaFaud4JYG9rOXvVYG8n3
         q3YnXD0wr9TIr9VVKJ6nZ+epO1i8fJb0fGw6epqQ67GyORw3NmxQ8LJ+PBJiJ/AwI5iD
         +TIoP2wjXVoTeXs1ouynBCRSZ2bQn4TGAYXiourpQHhUTion4dtUwOG4TABPCMAxjyKa
         TuXA==
X-Gm-Message-State: AOAM533NNZmz2xu8864nmD8MfIwxa9DaRt0IJ9VXxP+5Omc8iib+rrqx
	mBfw+S7AFzGW9otvpqB0srfSxA==
X-Google-Smtp-Source: ABdhPJxKiUYn1aRZ6+nMpF4mw2P7la2xk5Be8oAsrPjYjwiKpwMyOOokhTXMKKUlmGeo8RJshTrVUw==
X-Received: by 2002:a1c:2507:: with SMTP id l7mr5382109wml.186.1635845101369;
        Tue, 02 Nov 2021 02:25:01 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48])
        by smtp.gmail.com with ESMTPSA id u20sm1974711wmq.3.2021.11.02.02.25.00
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 02 Nov 2021 02:25:01 -0700 (PDT)
Date: Tue, 2 Nov 2021 09:24:59 +0000
From: "Leif Lindholm" <leif@nuviainc.com>
To: "brbarkel@microsoft.com" <bret@corthon.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg
Message-ID: <20211102092459.p32fpnudv4gco5tr@leviathan>
References: <20211101195648.6420-1-brbarkel@microsoft.com>
 <20211101195648.6420-8-brbarkel@microsoft.com>
MIME-Version: 1.0
In-Reply-To: <20211101195648.6420-8-brbarkel@microsoft.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 01, 2021 at 12:56:39 -0700, brbarkel@microsoft.com wrote:
> From: Bret Barkelew <brbarkel@microsoft.com>
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> ---
>  {ArmPkg => MdePkg}/Include/AsmMacroIoLib.h | 0

I approve of this move, but if it goes into MdePkg, it needs some form
of arch-specific handling (like ProcessorBind.h, and indeed for x86,
Nasm.inc).

I also note that the AArch64 version is not moved at the same time.
That seems counterintuituve.

So could you:
Move
ArmPkg/Include/AsmMacroIoLib.h => MdePkg/Include/ARM/AsmMacroIoLib.h
ArmPkg/Include/AsmMacroIoLibV8.h => MdePkg/Include/AArch64/AsmMacroIoLibV8.h
?

Ideally, the AArch64 version should also lose its spectacularly
incorrect suffix, but that can wait for another day due to the
resulting fallout.

Ideally2, the VS .inc files ought to move with the ARM header, but that
feels like a bit much of a can of worms to ask for.

/
    Leif

>  1 file changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/ArmPkg/Include/AsmMacroIoLib.h b/MdePkg/Include/AsmMacroIoLib.h
> similarity index 100%
> rename from ArmPkg/Include/AsmMacroIoLib.h
> rename to MdePkg/Include/AsmMacroIoLib.h
> -- 
> 2.31.1.windows.1
>