From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web12.6939.1635845671161040323 for ; Tue, 02 Nov 2021 02:34:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=azubXddU; spf=pass (domain: nuviainc.com, ip: 209.85.221.51, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f51.google.com with SMTP id u18so32266499wrg.5 for ; Tue, 02 Nov 2021 02:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VEApIMIccC/EVely+iFE8dJ6ASjlM2he1EoiT/AjVqg=; b=azubXddUB4PKbHKqyZ5oWR1fY+/BmhFsVkQZ7m/2ntYAkHWuZy/nTAbDWbU2kKRPkj Ju5nsiXYUCv7+TfAAgMlUuiZaLO1ZqikabkKfw6mfp2+7yPbbpvI/aVVEb6cvN48bL3I Rx3uj68UyiJPjgCRYquvJTHcGgsvmBHMtIvVrKx2I+NuXumW+8dlIsLDCqC4AYxdaPYu jLM5VDnFhcToSBfHpmq9iQ4DMCxrsw+oWJFtujn0yQw2j0Owd+pe2I8gX1PbDRc+V39L vlqYOODQpF+p3oJwlGEPsFaTldJ3t60CaYZGvHGguOSZ9qrw90Gbq0mBHdcr0jtqiG4r qcFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VEApIMIccC/EVely+iFE8dJ6ASjlM2he1EoiT/AjVqg=; b=A5s36fRL48uOAQmZurfBtalbl8ckMbXHc2Yb8LIkz82fr//rw1ELG32Qg01UyJJLtM rgEkiMWDDTg27dXH/tgZG/SVJDI7zWdRlLXi6GqVMV3w7S8OXNErVS9iiabqHxbrX2+s kizzcZ0MkoMYpCHyU88BDHJV56TY539s1MWCsIf0pAGQNa26ZN4wZ6OWzECsbO4euFkW /xeozH9JLn1m5z+EiG47UgGGXza8jhckQQeVqVHyzn7KpsyzHq67QqUteOFVLNf1XpKT smSTB1yT6jWRZXwQXE8kzr797dB/9gpBjRSGrDrmAMB6nqeUV44Z4qOzkmolMlygUsaT vB6w== X-Gm-Message-State: AOAM532dgsld7o+7z4a2wmNz9Z0T1S1QRwsoIYqw6fHcBy/LTQMa4ow9 OXJg9NFodcrlt/ePPO8TXA+QIA== X-Google-Smtp-Source: ABdhPJxc08SI02L7Bwd/uGtYHw34Mej/Tu731FDAMfrcRzL5+kqU13JUeSz5EUd15E88ovEwRqD2DA== X-Received: by 2002:a05:6000:1813:: with SMTP id m19mr35474567wrh.51.1635845669688; Tue, 02 Nov 2021 02:34:29 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id w1sm1883211wmc.19.2021.11.02.02.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 02:34:29 -0700 (PDT) Date: Tue, 2 Nov 2021 09:34:27 +0000 From: "Leif Lindholm" To: "brbarkel@microsoft.com" Cc: devel@edk2.groups.io, Ard Biesheuvel , Sean Brogan Subject: Re: [PATCH v1 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib Message-ID: <20211102093427.67uyhlezaht23gn7@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-3-brbarkel@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211101195648.6420-3-brbarkel@microsoft.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 01, 2021 at 12:56:34 -0700, brbarkel@microsoft.com wrote: > From: Bret Barkelew > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 The reference is good, but please still have a summary in the commit message. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 37 ++++++++++++++++++++ > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 2 +- > 2 files changed, 38 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c > index 20f873e6802c..42216bf40ac7 100644 > --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c > +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c > @@ -325,3 +325,40 @@ ArmClearMemoryRegionReadOnly ( > } > return Status; > } > + > +EFI_STATUS > +EFIAPI > +ArmConfigureMmu ( > + IN ARM_MEMORY_REGION_DESCRIPTOR *MemoryTable, > + OUT VOID **TranslationTableBase OPTIONAL, > + OUT UINTN *TranslationTableSize OPTIONAL > + ) > +{ > + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); > + ASSERT (FALSE); > + return EFI_UNSUPPORTED; > +} > + > +VOID > +EFIAPI > +ArmReplaceLiveTranslationEntry ( > + IN UINT64 *Entry, > + IN UINT64 Value, > + IN UINT64 RegionStart > + ) > +{ > + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); > + ASSERT (FALSE); > +} > + > +EFI_STATUS > +ArmSetMemoryAttributes ( > + IN EFI_PHYSICAL_ADDRESS BaseAddress, > + IN UINT64 Length, > + IN UINT64 Attributes > + ) > +{ > + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); > + ASSERT (FALSE); > + return EFI_UNSUPPORTED; > +} > diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > index ff20e5898051..d34086853d32 100644 > --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > @@ -13,7 +13,7 @@ [Defines] > FILE_GUID = 44a741c2-655f-41fc-b066-179f5a9aa78a > MODULE_TYPE = MM_CORE_STANDALONE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = StandaloneMmMmuLib > + LIBRARY_CLASS = ArmMmuLib | MM_CORE_STANDALONE MM_STANDALONE Although clearly an improvement, this hunk does not form part of the described change. Can you move it to 1/16? Indeed, if there are more "properly restrict modules to where they actually work" changes in the set, I'd rather see them all rolled up into one patch than sprinkled throughout. / Leif > PI_SPECIFICATION_VERSION = 0x00010032 > > [Sources] > -- > 2.31.1.windows.1 >