From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.groups.io with SMTP id smtpd.web12.6970.1635845951214024518 for ; Tue, 02 Nov 2021 02:39:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=l7Vi7KQt; spf=pass (domain: nuviainc.com, ip: 209.85.128.42, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f42.google.com with SMTP id f7-20020a1c1f07000000b0032ee11917ceso1615434wmf.0 for ; Tue, 02 Nov 2021 02:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bKHoDBGk9E9swK/i/pnkY5FrzxcQP5dRPzr+tFLFVfk=; b=l7Vi7KQt+TXiPiKBLhIgCwfNUaWwDek4Iorcy+A/gUJo2CUbNGQx5OZ4Ct6CNFiLiR ojdHWCWMQLyC58k/ZW6IWH2QXiTynr3bIw42yG1ZYQMWLEShAqy1YzZE3YCSJq8Drsqt BauIgunAnFWzzVn0hTf6XYjFAVpkDNaUDF9dVgPK9jHHaWXNDWUjHGAkea7dsDTb/vXb 8FB0H4EUYTxGNl5aSg6XcecphPQA9mEhrlNNayzbtz8WnzAhONy9Y0X+BM91yLXnyaMB n1bnPNvga6YQICZ05AHJd0LOuEgGWUluNzhrjlAFsLDHguRypK7jiDPJqpMpy8D3n4mz IEZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bKHoDBGk9E9swK/i/pnkY5FrzxcQP5dRPzr+tFLFVfk=; b=ETHibjp6nn3Y7bjnzRbjD8oBVClvG5PFzVfwo6BOiDhVvR4PblzvqisBOgn8c5+FGR bpAxJs4dKsD9MuxnZ11+kGhLS4p2mcyz7KLtyuxVYphN83ak4WnhKCXhA/41o9mEwRuz e5qy8LCyYVo6P7IxnYZl0kbZFK39BP0R2vnTy7aQqc3usS2RfROLcXu9jksP2VO+S/ch CyiFxRT8QLS0mzWhbtJ6vFFkXXBrKbXhXAyd/x2U5NW7RluIOrigNCi/IH/pnCsb+Zdc XK4lAGzZ514btm9dLhqUgzNgCRf+uhrkRhTAkoJiHH55fOQ1I0dGw12JwVq+HgOO3105 MT8A== X-Gm-Message-State: AOAM531RPF1ZWDyDp3dOrbbaFtz+McCLVVzRxDGfOBdpD9evSK5qxLr2 N8uDekRQNu4WT7f1g0xCNx+G1A== X-Google-Smtp-Source: ABdhPJyeOorW96lCx1ht0NMHFUQRfbH28c1vW2dIWYhJxFBa+CoucSa1/VvfC1eMRrRNnFOa/6QUig== X-Received: by 2002:a7b:cb07:: with SMTP id u7mr5521822wmj.178.1635845949545; Tue, 02 Nov 2021 02:39:09 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id g2sm16026084wrq.62.2021.11.02.02.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 02:39:09 -0700 (PDT) Date: Tue, 2 Nov 2021 09:39:07 +0000 From: "Leif Lindholm" To: "brbarkel@microsoft.com" Cc: devel@edk2.groups.io, Ard Biesheuvel , Sean Brogan Subject: Re: [PATCH v1 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib Message-ID: <20211102093907.totg5ijrdcioio2q@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-3-brbarkel@microsoft.com> <20211102093427.67uyhlezaht23gn7@leviathan> MIME-Version: 1.0 In-Reply-To: <20211102093427.67uyhlezaht23gn7@leviathan> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 02, 2021 at 09:34:27 +0000, Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:34 -0700, brbarkel@microsoft.com wrote: > > From: Bret Barkelew > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 > > The reference is good, but please still have a summary in the commit > message. > > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sean Brogan > > Signed-off-by: Bret Barkelew > > --- > > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 37 ++++++++++++++++++++ > > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 2 +- > > 2 files changed, 38 insertions(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c > > index 20f873e6802c..42216bf40ac7 100644 > > --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c > > +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c > > @@ -325,3 +325,40 @@ ArmClearMemoryRegionReadOnly ( > > } > > return Status; > > } > > + > > +EFI_STATUS > > +EFIAPI > > +ArmConfigureMmu ( > > + IN ARM_MEMORY_REGION_DESCRIPTOR *MemoryTable, > > + OUT VOID **TranslationTableBase OPTIONAL, > > + OUT UINTN *TranslationTableSize OPTIONAL > > + ) > > +{ > > + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); > > + ASSERT (FALSE); > > + return EFI_UNSUPPORTED; > > +} > > + > > +VOID > > +EFIAPI > > +ArmReplaceLiveTranslationEntry ( > > + IN UINT64 *Entry, > > + IN UINT64 Value, > > + IN UINT64 RegionStart > > + ) > > +{ > > + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); > > + ASSERT (FALSE); > > +} > > + > > +EFI_STATUS > > +ArmSetMemoryAttributes ( > > + IN EFI_PHYSICAL_ADDRESS BaseAddress, > > + IN UINT64 Length, > > + IN UINT64 Attributes > > + ) > > +{ > > + DEBUG ((DEBUG_ERROR, "%a() interface not implemented!\n", __FUNCTION__)); > > + ASSERT (FALSE); > > + return EFI_UNSUPPORTED; > > +} > > diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > > index ff20e5898051..d34086853d32 100644 > > --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > > +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > > @@ -13,7 +13,7 @@ [Defines] > > FILE_GUID = 44a741c2-655f-41fc-b066-179f5a9aa78a > > MODULE_TYPE = MM_CORE_STANDALONE > > VERSION_STRING = 1.0 > > - LIBRARY_CLASS = StandaloneMmMmuLib > > + LIBRARY_CLASS = ArmMmuLib | MM_CORE_STANDALONE MM_STANDALONE > > Although clearly an improvement, this hunk does not form part of the > described change. Can you move it to 1/16? > Indeed, if there are more "properly restrict modules to where they > actually work" changes in the set, I'd rather see them all rolled up > into one patch than sprinkled throughout. Or, you know, given 4/16, just don't add the restriction that obscures that you're changing the library class in the first place... > > / > Leif > > > PI_SPECIFICATION_VERSION = 0x00010032 > > > > [Sources] > > -- > > 2.31.1.windows.1 > >