Re: [PATCH v1 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

["Leif Lindholm" <leif@nuviainc.com>]

On Mon, Nov 01, 2021 at 12:56:36 -0700, brbarkel@microsoft.com wrote:
> From: Bret Barkelew <brbarkel@microsoft.com>
> 
> This extra interface is redundant and unnecessary. Dropping it is
> more EDK2-ish.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  ArmPkg/ArmPkg.dec                           |  4 ---
>  ArmPkg/Include/Library/StandaloneMmMmuLib.h | 36 --------------------
>  2 files changed, 40 deletions(-)
> 
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index 9da1bbc9f216..f5c235ecc11b 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -88,10 +88,6 @@ [LibraryClasses.common]
>    #
>    SemihostLib|Include/Library/SemihostLib.h
>  
> -  ##  @libraryclass  Provides an interface for a StandaloneMm Mmu.
> -  #
> -  StandaloneMmMmuLib|Include/Library/StandaloneMmMmuLib.h
> -
>  [Guids.common]
>    gArmTokenSpaceGuid       = { 0xBB11ECFE, 0x820F, 0x4968, { 0xBB, 0xA6, 0xF7, 0x6A, 0xFE, 0x30, 0x25, 0x96 } }
>  
> diff --git a/ArmPkg/Include/Library/StandaloneMmMmuLib.h b/ArmPkg/Include/Library/StandaloneMmMmuLib.h
> deleted file mode 100644
> index ccc016d0350a..000000000000
> --- a/ArmPkg/Include/Library/StandaloneMmMmuLib.h
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -/** @file
> -
> -  Copyright (c) 2018, ARM Ltd. All rights reserved.
> -
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> -
> -**/
> -
> -#ifndef STANDALONE_MM_MMU_LIB_
> -#define STANDALONE_MM_MMU_LIB_
> -
> -EFI_STATUS
> -ArmSetMemoryRegionNoExec (
> -  IN  EFI_PHYSICAL_ADDRESS      BaseAddress,
> -  IN  UINT64                    Length
> -  );
> -
> -EFI_STATUS
> -ArmClearMemoryRegionNoExec (
> -  IN  EFI_PHYSICAL_ADDRESS      BaseAddress,
> -  IN  UINT64                    Length
> -  );
> -
> -EFI_STATUS
> -ArmSetMemoryRegionReadOnly (
> -  IN  EFI_PHYSICAL_ADDRESS      BaseAddress,
> -  IN  UINT64                    Length
> -  );
> -
> -EFI_STATUS
> -ArmClearMemoryRegionReadOnly (
> -  IN  EFI_PHYSICAL_ADDRESS      BaseAddress,
> -  IN  UINT64                    Length
> -  );
> -
> -#endif /* STANDALONE_MM_MMU_LIB_ */
> -- 
> 2.31.1.windows.1
>