From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.web09.6959.1635846000699491654 for ; Tue, 02 Nov 2021 02:40:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=mp3z0ttv; spf=pass (domain: nuviainc.com, ip: 209.85.128.45, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f45.google.com with SMTP id d72-20020a1c1d4b000000b00331140f3dc8so1590928wmd.1 for ; Tue, 02 Nov 2021 02:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=miy0aXMg2M6NVywYM+85fTI2q70oJMi+D8+sJifxFWA=; b=mp3z0ttvSVaQddZFN+FVuBbLClyLZpDS1YbAi8MlZKrEgFyDpyLX6uUUWH9+QzluwY ZtuUvE5Jrruyg3TH/zTYLHmL0P5rkGHhLdN58QqGGEs9I4+RjPPcrFv6SFc4eKD/IVWp OkkoZaY5pnySoirl0knSBQq1rNzstB9qprgRHxqzf8Hxpz1c0xCZQOfE2uYzDV0RF4Lt fp/WdT42LT/gsjAl931c+XBJeEocHLDvj3AkcP85oxlk+Cd6MMptgf5VM3rfPRZ5RMh+ PaD/2B3JNxi/BTA+vMRM3p6HXN2Rccslw4hIVGX7kvbZzpSBWkouVxzFp1UPEFQOc1Lf YoZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=miy0aXMg2M6NVywYM+85fTI2q70oJMi+D8+sJifxFWA=; b=CkFsX8cjQ/Z5oYDhj0oYf2Pd1baFBvHsP6tFcKpK+CP0chUJczGjMZRkQXwRPR6jA+ a2Db3z+NSgvs+Ua3Ssh6aZUTY2hTakdsOZHlZ3wdGNPzN+AfpSTMEDqaSw/sCL7P/c9c gSiuGfpcQhJkFaXjVwcdRB7v2cVOF7vv5e2BJnitLWtUofQeRinjhz7tX5EMyyXfa+X/ XacufsJ/5COAbiaDG1TlPZo8bNbt6z856fXUb43s2QYnE2tFjFRY+cexNpWFJ8cQbDJx PbaO/lLVx4hzoBSQYjg4rmNp3fbP6Phs02OsEhA9SNE4z39DHNCCUkc1ydlo+S4J18vN q/5w== X-Gm-Message-State: AOAM530fXrtBR7chxXnPNDdRuGifkZJwIdJigQtvwx7Am/RfX2IR3uub aD0qlcWR4NGbZAC7Zwn27SpI9A== X-Google-Smtp-Source: ABdhPJypBay1zDu1GJPMD/0lH9f7MbOFZrVfeNCu8okm77BahqM0yZfIKBFsiGL+IUVADJ4DJ983fQ== X-Received: by 2002:a1c:2507:: with SMTP id l7mr5710372wml.144.1635845999354; Tue, 02 Nov 2021 02:39:59 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id m21sm11364493wrb.2.2021.11.02.02.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 02:39:59 -0700 (PDT) Date: Tue, 2 Nov 2021 09:39:57 +0000 From: "Leif Lindholm" To: "brbarkel@microsoft.com" Cc: devel@edk2.groups.io, Ard Biesheuvel , Sean Brogan Subject: Re: [PATCH v1 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib Message-ID: <20211102093957.jta5oftsbrdps7qb@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-5-brbarkel@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211101195648.6420-5-brbarkel@microsoft.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 01, 2021 at 12:56:36 -0700, brbarkel@microsoft.com wrote: > From: Bret Barkelew > > This extra interface is redundant and unnecessary. Dropping it is > more EDK2-ish. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sean Brogan > Signed-off-by: Bret Barkelew Reviewed-by: Leif Lindholm > --- > ArmPkg/ArmPkg.dec | 4 --- > ArmPkg/Include/Library/StandaloneMmMmuLib.h | 36 -------------------- > 2 files changed, 40 deletions(-) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index 9da1bbc9f216..f5c235ecc11b 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -88,10 +88,6 @@ [LibraryClasses.common] > # > SemihostLib|Include/Library/SemihostLib.h > > - ## @libraryclass Provides an interface for a StandaloneMm Mmu. > - # > - StandaloneMmMmuLib|Include/Library/StandaloneMmMmuLib.h > - > [Guids.common] > gArmTokenSpaceGuid = { 0xBB11ECFE, 0x820F, 0x4968, { 0xBB, 0xA6, 0xF7, 0x6A, 0xFE, 0x30, 0x25, 0x96 } } > > diff --git a/ArmPkg/Include/Library/StandaloneMmMmuLib.h b/ArmPkg/Include/Library/StandaloneMmMmuLib.h > deleted file mode 100644 > index ccc016d0350a..000000000000 > --- a/ArmPkg/Include/Library/StandaloneMmMmuLib.h > +++ /dev/null > @@ -1,36 +0,0 @@ > -/** @file > - > - Copyright (c) 2018, ARM Ltd. All rights reserved. > - > - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef STANDALONE_MM_MMU_LIB_ > -#define STANDALONE_MM_MMU_LIB_ > - > -EFI_STATUS > -ArmSetMemoryRegionNoExec ( > - IN EFI_PHYSICAL_ADDRESS BaseAddress, > - IN UINT64 Length > - ); > - > -EFI_STATUS > -ArmClearMemoryRegionNoExec ( > - IN EFI_PHYSICAL_ADDRESS BaseAddress, > - IN UINT64 Length > - ); > - > -EFI_STATUS > -ArmSetMemoryRegionReadOnly ( > - IN EFI_PHYSICAL_ADDRESS BaseAddress, > - IN UINT64 Length > - ); > - > -EFI_STATUS > -ArmClearMemoryRegionReadOnly ( > - IN EFI_PHYSICAL_ADDRESS BaseAddress, > - IN UINT64 Length > - ); > - > -#endif /* STANDALONE_MM_MMU_LIB_ */ > -- > 2.31.1.windows.1 >