From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.groups.io with SMTP id smtpd.web12.7128.1635847214053232946 for ; Tue, 02 Nov 2021 03:00:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=acrH9VEa; spf=pass (domain: nuviainc.com, ip: 209.85.221.42, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f42.google.com with SMTP id b12so27912529wrh.4 for ; Tue, 02 Nov 2021 03:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Zw2gjFgsbt64+kfHaIuFVcPicmqzzC+78eo84wHXUhs=; b=acrH9VEarIq0F/5Y5gz3kF7wi/T1m9nhk/jgcMrPyyLds4UOmbxfhZgXaJieCwfzJS HZH9BpsFAJ4xwPVpJpc7pAnJetYaxnDXfJW9WigrogcnZQVdWk3DkqZU7urq9NTqtWb7 /9gWdj6Cg7FE0Nf4fzxd2pvbHNhLK65wbCFZ1YmBvxTIRGwS2P+2BHyrcFn58Pmi3jku 4SJnKkNeHwecHxJod+KzBBy1U6KLNMVCQkpNxtYsJRqRWVIG4HkhosS6dPLEy1bSzNZ6 ysoJLU5m4uh1Z+0GT6995po+uoe1MfjtJKwswHpIkZE/ikclbk/mL6Rz1Abo/3WlOnTW vsew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Zw2gjFgsbt64+kfHaIuFVcPicmqzzC+78eo84wHXUhs=; b=q+6y0ta1puoykbPCn1hoD9LJeQygThBdSv6Q5RHNILD0d27bUoWWqTldQaccsDl23r rFvavkXYslcPQzJJ+zAacxlebyXLkMrbzF8151eFYgOJ0OmnNo2kZNgfv+Z0hHZCsYK0 bWxBAfkMYI26OJvsz28LXHWOOQ1OiOYCXWPV4jmlxjCRwRT93YkwGGNj2R9lrLLfxsgl HBJUAGSSpzYtSlubPkwuFTUHI1HsY/IvZ12mhdmpN2fmhFdQ8Sn1Ul2DOtiwWeA6Fzfo h1Wq5pMUJnJMIIeuFx/BNahXrDDs0CmUDlusNwkpUUvmOwzBzFcoT7Tg7ZQWoE5ktkc+ cKYg== X-Gm-Message-State: AOAM532D/YwKEWvHYo5XkaMhnrOH+2HOfOLAl+UDxop+GjRqqUDLbRYv R8HBfP0mfptZhoaS3HzqtpYN4g== X-Google-Smtp-Source: ABdhPJxch95XvJoAkV9Te1CdffgxYh06OlgGIK3E+cz7J11baQqEbBoyiu4aP8U0KFAuJ1vIqELWYA== X-Received: by 2002:adf:a78a:: with SMTP id j10mr46740474wrc.105.1635847212678; Tue, 02 Nov 2021 03:00:12 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id b6sm19066486wrd.85.2021.11.02.03.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 03:00:12 -0700 (PDT) Date: Tue, 2 Nov 2021 10:00:10 +0000 From: "Leif Lindholm" To: "brbarkel@microsoft.com" Cc: devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Sean Brogan Subject: Re: [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg Message-ID: <20211102100010.ddx7klcot5zhkxxl@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-13-brbarkel@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211101195648.6420-13-brbarkel@microsoft.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 01, 2021 at 12:56:44 -0700, brbarkel@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Basecore to have zero CI dependencies > on other Mu repos. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 I much prefer moving things out of ArmPkg (which shouldn't exist), than moving things into it. Where would be the logical place for this to go if ARM wasn't so special it needed its own top-level package? / Leif > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/EventHandle.c | 0 > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 0 > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/StandaloneMmCpu.h | 0 > {StandaloneMmPkg => ArmPkg}/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf | 0 > 4 files changed, 0 insertions(+), 0 deletions(-) > > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c b/ArmPkg/Drivers/StandaloneMmCpu/EventHandle.c > similarity index 100% > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c > rename to ArmPkg/Drivers/StandaloneMmCpu/EventHandle.c > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > similarity index 100% > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > similarity index 100% > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.h > diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf b/ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > similarity index 100% > rename from StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > rename to ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > -- > 2.31.1.windows.1 >