From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.groups.io with SMTP id smtpd.web09.7109.1635847257994888631 for ; Tue, 02 Nov 2021 03:00:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=Mm1r6p1/; spf=pass (domain: nuviainc.com, ip: 209.85.221.50, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f50.google.com with SMTP id d3so32325241wrh.8 for ; Tue, 02 Nov 2021 03:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jOfZphK+otxBd/POd7TfEmtNy+e2YHrUoy7FDTzSBWs=; b=Mm1r6p1/QLZfYSItpWjARoHYnak/RBK/jd8K1wUslPW68/i2mK0L2Rc5lAiOaSwN8J z/CORowKiA9WPfVzaz6wNiXlWsbNJa4Q80KrJ2FPYGQ9XIJUuLZIYNrGmbr3xfHJpAdk Qfk360pEhBnLZsGHD9P9Bl6aOySGk9hH3H3rpfulHnTZVgPf1SQHV7TmZJ4rpZPCusjg CgzJpbMQ34uqHz6xogQWXJC3mWx44qrv6SP/6ZJnCpwJsuAn4Ya4UVbBb1h4vfEmZ4HF hSocwQdxtJUvcXMZhVmRfO9gSzneWPw/+tnAmwLHVrlAkWsIAYJPCJynWnyXEXH+sDQw Rz9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jOfZphK+otxBd/POd7TfEmtNy+e2YHrUoy7FDTzSBWs=; b=KLgdtci7wcz7xVc+OusH/ExZR9mChAT2EPgVP9kYQ7kJsvkcx4mb/bcdznS7r3dXP3 LNwkMCy/W2zAji1tsAmJ4ndiMouDB2/bB0i01B5jcmj5QUdvqXsLjq/VPQG23pAPQD2K NITnRCpyNgpufGFWlO8+XIbjXBPmLMiuxtb9UsAz9xU+oNSUo6NVIOQmwvhl38ykQfK7 +Pw5ZmJlknTDhUHA5q4IXaXTNkc2y0SZKTUd/Q3I3VWq9mF8o9VuYk9m05dKVwnDOD5J GPO9FhWnhDbY1zuB1ZBJQIK1ouUGKV0EZRWj+pmawjVY/yXScu89+V1bBU/wlUNztXu1 UnKg== X-Gm-Message-State: AOAM533MQ2loMYkOClBTWm5rj13knK1DzisblEOuM9iz0tHY3u91rtto QAWk8mpwp+xLBBdK58284cjHPw== X-Google-Smtp-Source: ABdhPJwzuf2i2AYFmLAcmhv2Z75qMp1kVSNhBgsv7Y+Vyk8nUy7UtKBzh5KGzKVFafStJZiYGtjZjg== X-Received: by 2002:adf:df0d:: with SMTP id y13mr26755320wrl.176.1635847256624; Tue, 02 Nov 2021 03:00:56 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id u2sm15826511wrr.35.2021.11.02.03.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 03:00:56 -0700 (PDT) Date: Tue, 2 Nov 2021 10:00:54 +0000 From: "Leif Lindholm" To: "brbarkel@microsoft.com" Cc: devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Sean Brogan Subject: Re: [PATCH v1 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib to ArmPkg Message-ID: <20211102100054.t3wgixkiqdto6e3w@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-14-brbarkel@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211101195648.6420-14-brbarkel@microsoft.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 01, 2021 at 12:56:45 -0700, brbarkel@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Basecore to have zero CI dependencies > on other Mu repos. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 (Same comment as for preceding patch.) / Leif > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- > {StandaloneMmPkg => ArmPkg}/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c | 0 > {StandaloneMmPkg => ArmPkg}/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c | 0 > {StandaloneMmPkg => ArmPkg}/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEntryPoint.c | 0 > {StandaloneMmPkg => ArmPkg}/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c | 0 > ArmPkg/ArmPkg.ci.yaml | 3 ++- > ArmPkg/ArmPkg.dsc | 3 +++ > {StandaloneMmPkg => ArmPkg}/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf | 0 > 7 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c > similarity index 100% > rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c > rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c > similarity index 100% > rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c > rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEntryPoint.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEntryPoint.c > similarity index 100% > rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEntryPoint.c > rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEntryPoint.c > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c > similarity index 100% > rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c > rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c > diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml > index a0d6a75fe881..de6926c82e67 100644 > --- a/ArmPkg/ArmPkg.ci.yaml > +++ b/ArmPkg/ArmPkg.ci.yaml > @@ -46,7 +46,8 @@ > "EmbeddedPkg/EmbeddedPkg.dec", > "MdeModulePkg/MdeModulePkg.dec", > "MdePkg/MdePkg.dec", > - "ShellPkg/ShellPkg.dec" > + "ShellPkg/ShellPkg.dec", > + "StandaloneMmPkg/StandaloneMmPkg.dec" > ], > # For host based unit tests > "AcceptableDependencies-HOST_APPLICATION":[ > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index cbc67daa7696..4741a93f609a 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -159,6 +159,9 @@ [Components.common] > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > > + ArmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > + ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > + > [Components.AARCH64] > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf b/ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > similarity index 100% > rename from StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > rename to ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > -- > 2.31.1.windows.1 >