From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web11.7096.1635847550805098354 for ; Tue, 02 Nov 2021 03:05:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=lVnFYW5x; spf=pass (domain: nuviainc.com, ip: 209.85.128.53, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f53.google.com with SMTP id b2-20020a1c8002000000b0032fb900951eso1374177wmd.4 for ; Tue, 02 Nov 2021 03:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yqVDc+U5sDxHfiHojAZou9lpp/YEKxQIacmDrjKZ8cI=; b=lVnFYW5xwwG2otkSo7iezhD/q/B62aE7hoshrtfFkiyFr6j9HLMEBvBBsg4+7vyY3F ilLkP6qQpfx/aNoHxYYnAB54nheehUxlVZGsGi7wMpu98yULbrTU8StEAYKHRdGQJVSo 0kYbBdAUzG+UGqO5ltRk+SBchnXwgFzbJeF6dk8BVZ1GMtB5FDobW/cZmSoxTVoD4tFZ s2ctoygm0CfD6n6ULmQ5Qndkask1IWjXeYQIvDNnuhvpbfmIjQv5qnMRFcQUMdJmWGUo Nxol91hCt14vRNeG2lRaIu3bwMigORqZ3890xpo77qc8wj6cRd+AlTxnTJuWFWdAsRjb WYSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yqVDc+U5sDxHfiHojAZou9lpp/YEKxQIacmDrjKZ8cI=; b=ZzdMpc7n4nIMf3myRKHinGk5VoFWmgLDFw4Ps8mJrE9p5OeUprMTeodhflIhBmAFpn hnzbluz7hzW9Zhh8xrTwf99dwGAs3AlH/agKO8TNiqYLdKV3NDwI5efPQVL7CtMZU6s4 eSfyCDYe0dvRyPk+XoqIFbV7vumxp+05FBHtKw9y4E76TNC7jdE2LbY/0y9G7hqlLYpo daYI4zG9eqDkj+Yiwhb+3wnURZlOycg3f0CoZ66VlteTo3gFqNShwfpT7eapth0WjaZt ZHkEVEP+EYdURrMrdTFwcC/Zte7IjXwf4mY0Tk3yG4nz8SJeOnSplPbx0DP9PIyzJXA5 R39A== X-Gm-Message-State: AOAM533Z/zbZjlbNTJkynxms+4ZaCjVKTJyD7wUutc+XfdaglEtBt2uV 658VIq8Vt3e0+Jk3vaRZwQAkCw== X-Google-Smtp-Source: ABdhPJweR32oJ6r1zl4M0nsOD+uWnqqoOeLo6QVV9Gb1SdYmdpZDlsZYNlTm2T2l1HsVaUMxLzS9UA== X-Received: by 2002:a05:600c:198f:: with SMTP id t15mr38646wmq.94.1635847549341; Tue, 02 Nov 2021 03:05:49 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id x13sm12875602wrr.47.2021.11.02.03.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 03:05:48 -0700 (PDT) Date: Tue, 2 Nov 2021 10:05:47 +0000 From: "Leif Lindholm" To: "brbarkel@microsoft.com" Cc: devel@edk2.groups.io, Ard Biesheuvel , Sean Brogan , Sami Mujawar , Jiewen Yao Subject: Re: [PATCH v1 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only Message-ID: <20211102100547.xnfdlzsg25fcmf3i@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-15-brbarkel@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211101195648.6420-15-brbarkel@microsoft.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline + StandaloneMmPkg maintianers - this is their code. Sami: can you submit a patch to drop Supreeth please? / Leif On Mon, Nov 01, 2021 at 12:56:46 -0700, brbarkel@microsoft.com wrote: > From: Bret Barkelew > > Drop X64 references. Update GUID. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- > ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c | 71 -------------------- > ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf | 6 +- > 2 files changed, 2 insertions(+), 75 deletions(-) > > diff --git a/ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c b/ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c > deleted file mode 100644 > index dffa965b8425..000000000000 > --- a/ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c > +++ /dev/null > @@ -1,71 +0,0 @@ > -/** @file > - Entry point to the Standalone Mm Core. > - > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> -Copyright (c) Microsoft Corporation. > -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > - > -#include > - > -#include > -#include > -#include > - > -// > -// Cache copy of HobList pointer. > -// > -VOID *gHobList = NULL; > - > -/** > - The entry point of PE/COFF Image for the STANDALONE MM Core. > - > - This function is the entry point for the STANDALONE MM Core. This function is required to call > - ProcessModuleEntryPointList() and ProcessModuleEntryPointList() is never expected to return. > - The STANDALONE MM Core is responsible for calling ProcessLibraryConstructorList() as soon as the EFI > - System Table and the image handle for the STANDALONE MM Core itself have been established. > - If ProcessModuleEntryPointList() returns, then ASSERT() and halt the system. > - > - @param HobStart Pointer to the beginning of the HOB List passed in from the PEI Phase. > - > -**/ > -VOID > -EFIAPI > -_ModuleEntryPoint ( > - IN VOID *HobStart > - ) > -{ > - // > - // Cache a pointer to the HobList > - // > - gHobList = HobStart; > - > - // > - // Call the Standalone MM Core entry point > - // > - ProcessModuleEntryPointList (HobStart); > - > - // > - // TODO: Set page table here?? AARCH64 has this step for some reason > - // > -} > - > - > -/** > - Required by the EBC compiler and identical in functionality to _ModuleEntryPoint(). > - > - This function is required to call _ModuleEntryPoint() passing in HobStart. > - > - @param HobStart Pointer to the beginning of the HOB List passed in from the PEI Phase. > - > -**/ > -VOID > -EFIAPI > -EfiMain ( > - IN VOID *HobStart > - ) > -{ > - _ModuleEntryPoint (HobStart); > -} > diff --git a/ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf b/ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > index a0629cbc1a6f..c6b283653882 100644 > --- a/ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > +++ b/ArmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > @@ -10,8 +10,8 @@ > > [Defines] > INF_VERSION = 0x0001001A > - BASE_NAME = StandaloneMmCoreEntryPoint > - FILE_GUID = C97AC593-109A-4C63-905C-675FDE2689E8 > + BASE_NAME = ArmStandaloneMmCoreEntryPoint > + FILE_GUID = 0D7C6883-E1A8-4A7A-A35C-E0C200775B43 > MODULE_TYPE = MM_CORE_STANDALONE > VERSION_STRING = 1.0 > PI_SPECIFICATION_VERSION = 0x00010032 > @@ -26,8 +26,6 @@ [Sources.AARCH64, Sources.ARM] > Arm/SetPermissions.c > Arm/CreateHobList.c > > -[Sources.X64] > - X64/StandaloneMmCoreEntryPoint.c > > [Packages] > MdePkg/MdePkg.dec > -- > 2.31.1.windows.1 >