From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Dov Murik <dovmurik@linux.ibm.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
Subject: Re: [PATCH] OvmfPkg/AmdSev: Erase secret area content on ExitBootServices
Date: Tue, 2 Nov 2021 11:05:57 +0100 [thread overview]
Message-ID: <20211102100557.tcv5mfz2rpnmcrpa@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211102082506.366921-1-dovmurik@linux.ibm.com>
On Tue, Nov 02, 2021 at 08:25:06AM +0000, Dov Murik wrote:
> The confidential computing secrets area is marked as EfiBootServicesData
> region, which means it is released for the OS use when the OS EFI stub
> calls ExitBootServices. However, its content is not erased, and
> therefore the OS might unintentionally reuse this sensitive memory area
> and expose the injected secrets.
>
> Erase the content of the secret area on ExitBootServices so that the
> memory released to the OS contains zeros. If the OS needs to keep the
> secrets for its own use, it must copy the secrets area to another memory
> area before calling ExitBootServices (for example in efi/libstub in
> Linux).
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2021-11-02 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 8:25 [PATCH] OvmfPkg/AmdSev: Erase secret area content on ExitBootServices Dov Murik
2021-11-02 10:05 ` Gerd Hoffmann [this message]
2021-11-18 11:40 ` Dov Murik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102100557.tcv5mfz2rpnmcrpa@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox