From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.7346.1635848468212947448 for ; Tue, 02 Nov 2021 03:21:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EO2Ux5n1; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635848467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nd0oT3JkEPT5Z8x1ZnqVs0cxfD1EPy4Pf46FlFTANdw=; b=EO2Ux5n1UyhXu6en/l09sqF9oWmZ1EDaXGBE4euAo8RY0ffZBtNekrlsE5g4selNcS1NaU PEWf9xIeT/myNk3UG0uq0/fTjIFC3hoHXOBlrDqGxnrw3l7TQZFz7iZUe9l0ZvXiroQ+2i 7s+BwAo0+DEiTsiRI21GjOvqTuDEmDA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-Lo24Lhs3P3WFrVhMeUDB6w-1; Tue, 02 Nov 2021 06:21:04 -0400 X-MC-Unique: Lo24Lhs3P3WFrVhMeUDB6w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92C30180831B; Tue, 2 Nov 2021 10:21:02 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-241.phx2.redhat.com [10.3.112.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CD505D9D5; Tue, 2 Nov 2021 10:21:02 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 58A4C180092D; Tue, 2 Nov 2021 11:21:00 +0100 (CET) Date: Tue, 2 Nov 2021 11:21:00 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: "Xu, Min M" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , Erdem Aktas , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe Message-ID: <20211102102100.2k2rplncer3ytprg@sirius.home.kraxel.org> References: <20211102095849.xwhyj3xoz6uftypn@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 02, 2021 at 10:05:56AM +0000, Yao, Jiewen wrote: > We can state, this driver is to support fixed frequency. > If a real platform happens to have fixed frequency, then it can be used. > > gEfiMdePkgTokenSpaceGuid.PcdFSBClock is defined in MdePkg. > The consumer need set PcdFSBClock. > > I don't see a need to bind to OVMF. Not needed indeed, but I doubt it'll actually be used outside OvmfPkg for the reasons outlined in the last reply. When we move it out we should clearly document the PcdFSBClock so any potential users are aware of it. Maybe drop a short README into the directory then? take care, Gerd