From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.607.1635863773648686272
 for <devel@edk2.groups.io>;
 Tue, 02 Nov 2021 07:36:13 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KQQukJhP;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1635863772;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=PTw4gUhfHwqho9WbPWjfKkRwq9+mJoeuwef3fOc01Uo=;
	b=KQQukJhPMkuPVN5af7v4rbMrUH4bXrkHcyPAz4FRPYIxxpma565WFiJYCdoGuxEbMmx4DM
	vXz51QnzGlkWcC1xoLnRKFqkkvHFHqh09vZn8pWTvxrOKMqgMQK9ewbUfvFA6/BJ8nWIxu
	Di33SMZ0B52Px0UQO7YRAf9Zgu2DIF0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-352-C4-kx8--OT6T0VQas0bdxw-1; Tue, 02 Nov 2021 10:36:08 -0400
X-MC-Unique: C4-kx8--OT6T0VQas0bdxw-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D3A7927B94;
	Tue,  2 Nov 2021 14:34:08 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.194.99])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id C6ADA6A8E5;
	Tue,  2 Nov 2021 14:34:07 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id E9C81180092D; Tue,  2 Nov 2021 15:33:57 +0100 (CET)
Date: Tue, 2 Nov 2021 15:33:57 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 11/29] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib
Message-ID: <20211102143357.a7s5nuqghrs4agnh@sirius.home.kraxel.org>
References: <cover.1635769996.git.min.m.xu@intel.com>
 <985d8c0b1928a8f6df663011e03d6e987f2360b2.1635769996.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <985d8c0b1928a8f6df663011e03d6e987f2360b2.1635769996.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 01, 2021 at 09:16:00PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> 
> MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed
> directly from/to CPU. Some should be accessed via explicit requests
> from the host VMM using TDCALL(TDG.VP.VMCALL). This is done by the
> help of TdxLib.
> 
> Please refer to [TDX] Section 18.1
> TDX: https://software.intel.com/content/dam/develop/external/us/en/
> documents/tdx-module-1.0-public-spec-v0.931.pdf
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>