public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Dov Murik <dovmurik@linux.ibm.com>,
	James Bottomley <jejb@linux.ibm.com>,
	devel@edk2.groups.io, Brijesh Singh <brijesh.singh@amd.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>
Subject: Re: [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD
Date: Wed, 3 Nov 2021 07:07:11 +0100	[thread overview]
Message-ID: <20211103060711.uaalevtxebwfnvgg@sirius.home.kraxel.org> (raw)
In-Reply-To: <5f3cbabe-9a50-662a-16d9-09a1d04a3542@amd.com>

  Hi,

> > > Does SEV need and/or use SMM mode?  Looking through AmdSevX64.dsc
> > > doesn't give a clear answer, on one hand there is a
> > > LibraryClasses.common.SMM_CORE section, but on the other hand it uses
> > > the non-SMM variable driver stack.
> > 
> > I think SEV doesn't work with SMM.  James - can you please give a more
> > definitive answer here?
> 
> SEV works with SMM, but SEV-ES (and likely SEV-SNP) doesn't work with SMM
> because of the fact that the hypervisor wants to change the guest register
> state to enter SMM, which isn't allowed and results in a VMRUN failure.

Ok.  So the same reason why TDX doesn't support SMM either.

> It might be possible to get SMM to work by having separate VMSAs for the SMM
> state, but it is not anything that really has been investigated too deeply.

Should we just drop the SMM leftovers in AmdSevX64.{dsc,fdf} then?

take care,
  Gerd


  reply	other threads:[~2021-11-03  6:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02  7:34 [PATCH 0/2] OvmgPkg: Add SEV launch secret and hashes table areas Dov Murik
2021-11-02  7:34 ` [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD Dov Murik
2021-11-02 10:03   ` Gerd Hoffmann
2021-11-02 11:46     ` Dov Murik
2021-11-02 13:29       ` Gerd Hoffmann
2021-11-02 13:53         ` Dov Murik
2021-11-02 14:11           ` Lendacky, Thomas
2021-11-03  6:07             ` Gerd Hoffmann [this message]
2021-11-03  8:13               ` Dov Murik
2021-11-02  7:34 ` [PATCH 2/2] OvmfPkg/Microvm: " Dov Murik
2021-11-02 10:04 ` [PATCH 0/2] OvmgPkg: Add SEV launch secret and hashes table areas Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103060711.uaalevtxebwfnvgg@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox