From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.4067.1635921054945579778 for ; Tue, 02 Nov 2021 23:30:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iw+bYchE; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635921054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n8Fj4ljTQkGVebWfrXTr4RW6A9Lf9yMCUQyzlYzZJy4=; b=iw+bYchEeIR2i0EhT4Xa3Yw7BCaA8u7qfIW1W5J5Tkbv5e4qikOMdBecLK1xx8rUyCbKt/ qHHgEvnxBKSs7WRE9js/L9TGY2KBH45mqbFl6bdIxczIvh6BWC7DXjtCy7neQVM1qgwjhs w0njJtAllp/5IY6OJ8V+javZhvYEPf0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-oHBbZVusMN2tl3XTdpwt0w-1; Wed, 03 Nov 2021 02:30:48 -0400 X-MC-Unique: oHBbZVusMN2tl3XTdpwt0w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 35659180831E; Wed, 3 Nov 2021 06:30:47 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1F2C5D9D5; Wed, 3 Nov 2021 06:30:46 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3CD6B1800924; Wed, 3 Nov 2021 07:30:45 +0100 (CET) Date: Wed, 3 Nov 2021 07:30:45 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx Message-ID: <20211103063045.kmttoxyluifwo2bq@sirius.home.kraxel.org> References: <867e8a2aaf28c308b20a659057217453c6e38e00.1635769996.git.min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <867e8a2aaf28c308b20a659057217453c6e38e00.1635769996.git.min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > - AcceptPages: > To mitigate the performance impact of accepting pages in SEC phase on > BSP, BSP will parse memory resources and assign each AP the task of > accepting a subset of pages. This command may be called several times > until all memory resources are processed. In accepting pages, PageLevel > may fall back to smaller one if SIZE_MISMATCH error is returned. Why add an assembler version of this? There already is a C version (in TdxLib, patch #2). When adding lazy accept at some point in the future we will stop accepting all pages in the SEC phase anyway. There is Mp support (patch #14) so you can distribute the load to all CPUs in PEI / DXE phase if you want (although the benefits of parallel accept will be much smaller once lazy accept is there). take care, Gerd