From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.4087.1635922241137532420
 for <devel@edk2.groups.io>;
 Tue, 02 Nov 2021 23:50:41 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MW1Eotdw;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1635922240;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5eD7SasNnFAWbm19RJNtTRz5zvhnu5wJ4uffIzfukVI=;
	b=MW1EotdwawxfhqNmuG/ZWFgBuA5c1nUaorQg21gosYsfUr5u3sCCErEfH8Ub57lQS9Jmn4
	vHVORg0NqXDP3LPb8ZHo24EnCCvNwzDmZBZ7qJ4fPklSSUBGZkTcY8BNW47jDUUuAVZafD
	Ka63e9oyZNhQ9b0qdrG46+4n+QV+Q/c=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-450-6Y-NADgVOq-2EkWL6lQPsg-1; Wed, 03 Nov 2021 02:50:35 -0400
X-MC-Unique: 6Y-NADgVOq-2EkWL6lQPsg-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6195F879500;
	Wed,  3 Nov 2021 06:50:33 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.194.99])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id D89645C1BB;
	Wed,  3 Nov 2021 06:50:32 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 31C081800924; Wed,  3 Nov 2021 07:50:31 +0100 (CET)
Date: Wed, 3 Nov 2021 07:50:31 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 20/29] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation
Message-ID: <20211103065031.kqufl5dzhg36yr2u@sirius.home.kraxel.org>
References: <cover.1635769996.git.min.m.xu@intel.com>
 <28b60881586486d571be0c489b60784954dc061f.1635769996.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <28b60881586486d571be0c489b60784954dc061f.1635769996.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +/**
> +  Check if it is Tdx guest
> +
> +  @retval    TRUE   It is Tdx guest
> +  @retval    FALSE  It is not Tdx guest
> +**/
> +BOOLEAN
> +QemuFwCfgIsTdxGuest (

QemuFwCfgIsCC()

> +  return (CcWorkAreaHeader != NULL && CcWorkAreaHeader->GuestType == GUEST_TYPE_INTEL_TDX);

GuestType != GUEST_TYPE_NON_ENCRYPTED

>      if (MemEncryptSevIsEnabled ()) {
>        DEBUG ((DEBUG_INFO, "SEV: QemuFwCfg fallback to IO Port interface.\n"));
> +    } else if (QemuFwCfgIsTdxGuest ()) {

if (QemuFwCfgIsCC()

take care,
  Gerd