From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.4224.1635922651374111634
 for <devel@edk2.groups.io>;
 Tue, 02 Nov 2021 23:57:31 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NJoWgDBm;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1635922650;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=1u0aUaeSGvBSnxV6WoNfpwNkqL6LVnJZSmxwydJgkk4=;
	b=NJoWgDBmdJkOoyQRnawNOmDgsiq4Rt88RrCQ0467eD6oidgRqwpGYeng3htf0AhU4ZjqFF
	XFQVI1WE3Gtf1ewXb/Z7a8s8trlKdTlsXv6UiN+a83Ot902FynTX8txIdkuNqfsX9Z3yC7
	wnEYb99DZxqgWE/5YeFNBLqwb0FPxTQ=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-287-J5pSJP1JPzyCB1osqgC7xg-1; Wed, 03 Nov 2021 02:57:29 -0400
X-MC-Unique: J5pSJP1JPzyCB1osqgC7xg-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 87598806688;
	Wed,  3 Nov 2021 06:57:27 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.194.99])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 436035D9D5;
	Wed,  3 Nov 2021 06:57:27 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 8EB5E1800924; Wed,  3 Nov 2021 07:57:25 +0100 (CET)
Date: Wed, 3 Nov 2021 07:57:25 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 22/29] MdeModulePkg: Set shared bit in Mmio region for Tdx guest
Message-ID: <20211103065725.wdwzz5ki2rlyqcp3@sirius.home.kraxel.org>
References: <cover.1635769996.git.min.m.xu@intel.com>
 <e0d04467201923e90703757486f10b872e6444e4.1635769996.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <e0d04467201923e90703757486f10b872e6444e4.1635769996.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +++ b/MdeModulePkg/Core/DxeIplPeim/X64/DxeIplTdVmcall.nasm
> @@ -0,0 +1,146 @@
> +;------------------------------------------------------------------------------
> +;*
> +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
> +;* SPDX-License-Identifier: BSD-2-Clause-Patent
> +;*
> +;*
> +;------------------------------------------------------------------------------
> +
> +DEFAULT REL
> +SECTION .text
> +
> +%define TDVMCALL_EXPOSE_REGS_MASK       0xffec
> +%define TDVMCALL                        0x0
> +%define EXIT_REASON_CPUID               0xa
> +
> +%macro tdcall 0
> +    db 0x66,0x0f,0x01,0xcc
> +%endmacro

Again, shouldn't this just call TdxLib instead of having its own copy?

take care,
  Gerd