From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.4200.1635923424180319898
 for <devel@edk2.groups.io>;
 Wed, 03 Nov 2021 00:10:24 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aTRE5xGD;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1635923423;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=2u7KC4VQRDgjJSyzOhAce74XYGbpvq86NTY7nV8vFP4=;
	b=aTRE5xGD3vyjDKeNw/xXZbITwdrQh+BYvUY1vXAazzTZu4uTmD3rJXtjccTt4quVGDZDzN
	NJ11fl9T5+z3Lvp4dZHJfmWASHwJo164e0yAbJg/lgxgin4VGuU0wDC/WIcpy+vsOYfs6P
	yTVIBLZ+zCK7HeQYeERi2R3RDOYj1FM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-324-ZMb_7V5bNlm_bmY_b8m_Sw-1; Wed, 03 Nov 2021 03:10:20 -0400
X-MC-Unique: ZMb_7V5bNlm_bmY_b8m_Sw-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 851A3871805;
	Wed,  3 Nov 2021 07:10:18 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.194.99])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id DFAD919723;
	Wed,  3 Nov 2021 07:10:17 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 5B27F1800924; Wed,  3 Nov 2021 08:10:16 +0100 (CET)
Date: Wed, 3 Nov 2021 08:10:16 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 27/29] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library
Message-ID: <20211103071016.eyhqna3ydekf6egi@sirius.home.kraxel.org>
References: <cover.1635769996.git.min.m.xu@intel.com>
 <9ad859590b430fddb8ce9f0ebdecb8b06d9b7f4f.1635769996.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <9ad859590b430fddb8ce9f0ebdecb8b06d9b7f4f.1635769996.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 01, 2021 at 09:16:16PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> 
> Add Intel Tdx helper library. The library provides the routines to:
> -  set or clear Shared bit for a given memory region.
> -  query whether TDX is enabled.

Hmm, patch 22 adds functions to set the shared bit too.
Looks like duplicate functionality on a first glance.

take care,
  Gerd