From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.4224.1635923571805312145 for ; Wed, 03 Nov 2021 00:12:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NHMPVEl5; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635923570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3MZTk+f8yc3NqnpnIoIwQvfHf6Yc+4o++S6eT+iYpCE=; b=NHMPVEl5dvzmQNEG1EIfHIygpACphatj4AoP+Ms/Y8WNw+ak8OQXce4HbLEle0fxwYWG2Z dtmGFk3uTnmbl8abeSNTpmbPV4lev+w2UH1xVCz4Y9ZUJqitWctBhJHnH2h+nUIKf9hRS7 dmuNynUqHz3McYFMaiOUnamRjEHV6MM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-fff1X8InMZqrjPOKx0mWNA-1; Wed, 03 Nov 2021 03:12:47 -0400 X-MC-Unique: fff1X8InMZqrjPOKx0mWNA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14ED187180C; Wed, 3 Nov 2021 07:12:46 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C67075C1C5; Wed, 3 Nov 2021 07:12:45 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 336281800924; Wed, 3 Nov 2021 08:12:44 +0100 (CET) Date: Wed, 3 Nov 2021 08:12:44 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [PATCH V3 28/29] OvmfPkg/QemuFwCfgLib: Support Tdx in QemuFwCfgDxe Message-ID: <20211103071244.f2z76en5lybvax7a@sirius.home.kraxel.org> References: <8e1c23a097576afbdebaffc6ca5f28c608e1b526.1635769996.git.min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <8e1c23a097576afbdebaffc6ca5f28c608e1b526.1635769996.git.min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 01, 2021 at 09:16:17PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > In the previous QemuFwCfgDxe only SEV is supported. This commit > introduce TDX support in QemuFwCfgDxe. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Signed-off-by: Min Xu > --- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 9 +++++---- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf | 1 + > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > index 0182c9235cac..7a60b3e82863 100644 > --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > > #include "QemuFwCfgLibInternal.h" > @@ -85,7 +86,7 @@ QemuFwCfgInitialize ( > DEBUG ((DEBUG_INFO, "QemuFwCfg interface (DMA) is supported.\n")); > } > > - if (mQemuFwCfgDmaSupported && MemEncryptSevIsEnabled ()) { > + if (mQemuFwCfgDmaSupported && (MemEncryptSevIsEnabled () || (MemEncryptTdxIsEnabled ()))) { > EFI_STATUS Status; Should be possible to just check the ConfidentialComputing PCD here. take care, Gerd