From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web08.5887.1635937389353464618 for ; Wed, 03 Nov 2021 04:03:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=Ur1K9IXq; spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f48.google.com with SMTP id y196so1618861wmc.3 for ; Wed, 03 Nov 2021 04:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HE5LRDNRJnkefKEYi0pjkuP/qx+IllV8Ex4ePgaioDI=; b=Ur1K9IXqfAv5vNM2ES+1kfW8ml0awEXyAd5OA7OhM5gKBFaapTL4louONclEpG2bDc bBG8BSZCboZsNEQuL/FLedDNbH/LMM+/6HAt6a+7W+x4xWaNmOZ/RM19dK8R/8fpFriQ IGDxhOk7/tVHdoqclvHLLD/tAxVTMbqs1O3Hx6vL6/yhCDrM3ObOqPBmIHfEM1jSBYmi CtWafDYVCRuXQe/aBIuaRCIvvZAXMv7UsIIHaylJvJvciYpfU9MeobtWLb5Nf8MZhwnp J2q9rr3QCj7/hBB8rqPvoUL+b3qAu7FeLFI3/jbtRm/DsedSbz1imHqVYpDdJK07Vsp4 Xfmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HE5LRDNRJnkefKEYi0pjkuP/qx+IllV8Ex4ePgaioDI=; b=MiN7E0vbg16r0YGBa1dmhQkxMy7OyX09KX6xjRWXBFx5wrLDmsQcu2aZbqq+8p6oAF 9Gg3dOcJhVVhKcZb+3LC9y9xb8FTb+pA9GslL3JLXHrZFrFUV4fAyfeSdimm/r53JwHF TbORt95Dl3YueaJS2CeUpuzbvMHrkgseDbTthn91YfO5mwFyJxUiEkAKJpyoUswRJ5AU 1HPiNlOcR4W6DxvpDPVV8WN1v85GzY0CcnVuFxvL17MUwpbL8uau40QZHqWbf9Sv69C2 leQYG0GZ09KOIpaGvPAwSlanhgSZqCwxH0OykqbLDzzOc2+VtimglGRDibugM5AJOq43 49jw== X-Gm-Message-State: AOAM533vdUInJ+QNxog/fibX8feA0sodGML4iKLJVAKtGG8NpVfHq3Nz 8bzSps1J8/NCUEbJgKlGQpZc+25Y1CbJx0NFzKSyxjV0CeQpdiSh3ZVbaIvMMAgrPE7LhpfY+eM 1k0+afj4d2X7bJhhy+RrV6wsZO1XpkRapkSMaaA+TXNDyz8MlrX8ha7aGikbPgODsc+rI X-Google-Smtp-Source: ABdhPJyZoZMk8HgyUL26fqi+2qf3ecdqdzvSUkNyr0CLYpF77rzxTs/wkV0nP3xBgEULnF90HS9nXA== X-Received: by 2002:a05:600c:a08:: with SMTP id z8mr14361358wmp.52.1635937387713; Wed, 03 Nov 2021 04:03:07 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id o17sm5461077wmq.11.2021.11.03.04.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 04:03:07 -0700 (PDT) Date: Wed, 3 Nov 2021 11:03:05 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, afish@apple.com Cc: bret.barkelew@microsoft.com, "brbarkel@microsoft.com" , Ard Biesheuvel , "Feng, Bob C" , Liming Gao , "Chen, Yuwei" , Sean Brogan Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools Message-ID: <20211103110305.xieknjdjaiqncwsv@leviathan> References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-7-brbarkel@microsoft.com> <20211102095514.o5ermrxjikklgy3n@leviathan> <400DC68B-F514-40DD-9405-84ED342BB948@apple.com> MIME-Version: 1.0 In-Reply-To: <400DC68B-F514-40DD-9405-84ED342BB948@apple.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Nov 02, 2021 at 16:34:15 -0700, Andrew Fish via groups.io wrote: > > No objections to this for any of my use-cases, but I'd like for one of > > the BaseTools maintainers to comment on whether this breaks anything > > with regards to EDK_TOOLS_PATH, or if we can finally get rid of that > > and replace it with $WORKSPACE/BaseTools globally. > > > > > Our internal repo uses EDK_TOOLS_PATH. In our case it is > $(WORKSPACE)/edk2/BaseTools. We have a PACKAGES_PATH set to > $(WORKSPACE)/edk2 and magic happens. > > So I’m thinking maybe: > $(EDK_TOOLS_PATH)/Bin/GccLto > Vs: > $(WORKSPACE)/BaseTools/Bin/GccLto > > If EDK_TOOLS_PATH gets ripped out, it should be one atomic remove, > but let us not stick that on Bret. Agreed. I'd be happy with your proposed solution. / Leif