From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.9235.1635952632056075482 for ; Wed, 03 Nov 2021 08:17:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Mn2umskL; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id ADB7C20A8623; Wed, 3 Nov 2021 08:17:10 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ADB7C20A8623 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1635952631; bh=/aRAZjH2KoMpGxbMnM+p2/vThKTLT2VZa4GWhG7kCrM=; h=From:To:Cc:Subject:Date:From; b=Mn2umskLGyvJHeS6+59QQoQA8IFG1ahScjRHQ4Iux85pFdfnaUb1tNj5UT7/cFUxv 8XYU4kb9QqFMStc/qhhJsTotGP293oVc1G+qhg1S6yZYmaev257FJxyacPnPQlQvDt MerIjkaakk1SSusrS09Oqs/reudFSUBAp6Bkx5FA= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Jian J Wang , Liming Gao , Hao A Wu , Ray Ni Subject: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments Date: Wed, 3 Nov 2021 11:16:25 -0400 Message-Id: <20211103151625.2992-1-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3662 Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument that should be passed for the print specifier. In addition, this change updates the print level to "DEBUG_ERROR" and prints the status as well. Cc: Jian J Wang Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Michael Kubacki --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/= Pci/XhciDxe/XhciSched.c index 7cbc9a8502ea..6fcd2be6277c 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c @@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot ( DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", Device= Address)); Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; } else { - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n")); + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully.= Status =3D %r\n", SlotId, Status)); XhcDisableSlotCmd (Xhc, SlotId); } =20 @@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 ( DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", Device= Address)); Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; } else { - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n")); + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully.= Status =3D %r\n", SlotId, Status)); XhcDisableSlotCmd64 (Xhc, SlotId); } =20 --=20 2.28.0.windows.1