From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.73]) by mx.groups.io with SMTP id smtpd.web11.9610.1635954101909744510 for ; Wed, 03 Nov 2021 08:41:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=5LfDJEZz; spf=pass (domain: arm.com, ip: 40.107.4.73, mailfrom: christopher.jones@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NKEIbCHgLXLrXdpSyXTkUNKZ4ouxxAn6gTA1n2uEjZs=; b=5LfDJEZz/yQqHmpYl/5jkK7fNqIsu+O0KhEjv0CLyK/dbX7TAz/vFXCE58vHJVbEEb+J1BA0onI/y46ZZ8k8oAhgqQozurvK80Q2SdceYaXRoEjRI6UdfSJlo3uwSP8v9eZRr7/hWyrmadW9gQnmLrRpZUtJGslzi6I75slKFVE= Received: from DB6PR0202CA0028.eurprd02.prod.outlook.com (2603:10a6:4:a5::14) by DB9PR08MB7022.eurprd08.prod.outlook.com (2603:10a6:10:2c9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 3 Nov 2021 15:41:38 +0000 Received: from DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::b4) by DB6PR0202CA0028.outlook.office365.com (2603:10a6:4:a5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 3 Nov 2021 15:41:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT009.mail.protection.outlook.com (10.152.20.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Wed, 3 Nov 2021 15:41:38 +0000 Received: ("Tessian outbound 7b0bcc4a550a:v108"); Wed, 03 Nov 2021 15:41:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2980863ea49d66dc X-CR-MTA-TID: 64aa7808 Received: from 33169af635ae.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3B7099AE-9176-4126-B832-AF994F0A6ACB.1; Wed, 03 Nov 2021 15:41:31 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 33169af635ae.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Nov 2021 15:41:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVRH4NDaFIDWpOSC3KaprEwHOsUfQSLtr26KbeU15YIFh7E6qFItBOw9uD1Jxog6+II/GOhJ08Ljx7hwbALAaDw6EyMMqEzbwSf0IF9+ZGRk0mZGpyFALx7Xhv0T5Zwrxi0n/KBwYp+K4H+3mMV3Q/Wf5Gy17urkccTEbD6/Poz2WH9lmfBK7rreT6ldnuw9N813cDnW9QyUrTUoG74kf8WTIo/7DPpgdxrOUaXqcq5IlMY4f5w4BwoOfoTsI3azua7OAP3TDKOX5WTYjPYDAuFZrTy/ppWPvtQAM6w8vDWMzdACVPR63BrC0sBur4yvtJLojTRe3EKI52kwJWr/+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NKEIbCHgLXLrXdpSyXTkUNKZ4ouxxAn6gTA1n2uEjZs=; b=A3DiebKFlUjXs+l1Aufq5G7tZjJjp0ByK2QOgmesNJNpjvRdnuDKSBU2HbgJvDCZuMtGY4dms9QL7nitg751fg/OFtjwzbFOL7sy+qRnEzoc1VxnnCMG+/Zw0RpKVy4jxAyN0CN/j+COIl2Eo4ZAU5AKCmnZ7wW/pgXo2Y4Twc5CpWjaxnBbt8DbnRtVrC8HDE/iyF3DApgRSJMQqyIygaa5VUMWVknGgEWj0mJlsnLc5lsPwv4HbMRdT63NZ20Z7g5RXEDHsYeJFiucQ3P5JsklCbCGxwkIx9c1uDtfX81ygIY4EokH71C295/5mOTfoHwQ+Xl+Jx6m8eutxH+5Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NKEIbCHgLXLrXdpSyXTkUNKZ4ouxxAn6gTA1n2uEjZs=; b=5LfDJEZz/yQqHmpYl/5jkK7fNqIsu+O0KhEjv0CLyK/dbX7TAz/vFXCE58vHJVbEEb+J1BA0onI/y46ZZ8k8oAhgqQozurvK80Q2SdceYaXRoEjRI6UdfSJlo3uwSP8v9eZRr7/hWyrmadW9gQnmLrRpZUtJGslzi6I75slKFVE= Received: from AM6P192CA0070.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::47) by AS8PR08MB7267.eurprd08.prod.outlook.com (2603:10a6:20b:422::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 3 Nov 2021 15:41:29 +0000 Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::2d) by AM6P192CA0070.outlook.office365.com (2603:10a6:209:82::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17 via Frontend Transport; Wed, 3 Nov 2021 15:41:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4649.14 via Frontend Transport; Wed, 3 Nov 2021 15:41:28 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 3 Nov 2021 15:41:16 +0000 Received: from e125153.arm.com (10.57.26.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 3 Nov 2021 15:41:16 +0000 From: "Chris Jones" To: CC: , , , , , , , Subject: [PATCH v2 4/7] ShellPkg: Add Cache ID to PPTT parser Date: Wed, 3 Nov 2021 15:41:05 +0000 Message-ID: <20211103154108.6534-5-christopher.jones@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211103154108.6534-1-christopher.jones@arm.com> References: <20211103154108.6534-1-christopher.jones@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cfdf221f-bc08-4c90-b4d3-08d99ee06ccf X-MS-TrafficTypeDiagnostic: AS8PR08MB7267:|DB9PR08MB7022: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aGCts37njrQPnl7OHXmBJ0UTzWlwFZjSvQ3Y8vOOflkBR5oim6DpYKc1SoEOv5TRKkd7xt/TixD3e1qNS7wKoeWTN4dSw6MDYhXgfC7EvnX/YO5p2ebSdYrNxYy0qMvXjJ9Hixq+CXMTPAKFnFXeOi9oYx9j3AkAweRtp4ihx+zglRclx3dt010DkZzz2FG7GRkOEXGvc4hwIsIdcb1qm2gKsesT1E0SOhl1rCVfhdfH8K21eHqVlMo2++jt+IcSZQqb75inUiPep1LYx1bZo8Cm0WASJsgVeYOuRgtHy08InZNePr2FAsCeUZkyna6FnhJ1uxuvnhkBxx0AIODKB8OwfT793mziwDyqV/6bzveIzTMm0Fgu60g54r8ZSmo9U4H3mQI9v8jLzyE96lPq2GcIwfEljggkZBn+I+RPoyC916XAIVmsEXbJ8M/iml9wfjJ96jWUGDoDNcv63veeurvheXb7wL41mIlm8qbbZKuFhLf/beR1YuCm959NC/44YTm+kVfNY1LrvbYQp2z/wXAvEqZT23cezspX8hvEVqMkO/ffNQ4LR6zLfFHYyI4exPJdZKtsKqS7F5yDHLB5+iBO//79VcmpZ4IEfnJLZDqWLayV9JA+bqPe6fnDXhpXPhNoOW9u0wOOWqu17AOtVFFCzvGoA6i31HR7gYcl4YLHSaOBVa8xE0Rr9LtYGt6ifYfPTbpey6prjVR0rEgz5S0qp4eAoZjaHC0VCwAFrx4K6UKDARKETAsfLJd9rfzOEKTFXDy8lcZH8v0kecP0E6hv8yzKKWQ9wvtIHOxhVFUk+04FA4arcRZimNk2thnX X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(186003)(1076003)(426003)(2906002)(70586007)(70206006)(54906003)(82310400003)(86362001)(8676002)(4326008)(316002)(5660300002)(36860700001)(6666004)(36756003)(7696005)(2616005)(26005)(6916009)(336012)(83380400001)(356005)(81166007)(47076005)(508600001)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7267 Return-Path: Christopher.Jones@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c0257ff-baba-441d-62ab-08d99ee066fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XbOhpZ+LlFycqsmTwsAHkusbhvg0FgdFVE1g+hbwSwv7WTjIfE1EzGVzPssJ6bxHvGUFK2Cry9CzpLCOmSC4osuiapRbc+3lGlmpTz+7U6XsdPR/k1DczL2O2S+6vLo8sSx3BvMnib3GalEH8OX+5MFNPWFJ/vJ/kG84F3KL5s101Lb/x3ArfTYJiGL+c837KIPfEsKF7xbX2ff0pWAcw4D+ZElNtYwCfGkU3QMdYsulriNGj0Y7QkcfuTPdIh970Z1xZuw51s+N2W6T73tQtI1YunV+E5/h449JmO5108lnQHeJBWj3Wrfo2VoZWQKtDZNIV1cbGwEAWGtnzgvMVWyfp1Im8HXOk5U2ya9lx3R03XB0IVL8r4J+aJ3gg9ZQAZPQXuXk5DaS5wKzipBGGvyrYfyjmW8kzYR9qOGwJMMrE9K+1s3E+H8//8W2ds7fo2L5LU2ZpozBv4djpL3NcDO97HNh117S/JKdx20rs0YuqLhqU5ltUMYczitLPJRb+SH/KBPjA/nczOCbk0+I0IQ89o0NCIExHfzxCGOGci2c/o0HV6CONSpKKrb4IYz5c7xFIiDQZqypXG9fXThuD1EGZfykm1qZetIgCVRmZEF0TYHAYD4cO96+Do3Iihbh8LkB21jhXSMIOgxCT6vujmuGjuIYpldaGuILtyEyuql2qtz/s1F7htErDMDlvYlUpxtSSfmsz+vZzxjFrWdaUa5Wl+VsIhNtiCgCJWsDaNwOVv1qAuG4JRYS6v58xP6ED3fpVwCMViQ1YB+GLf/uWhTjfENdTCv7djpgXIaDcYo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(81166007)(4326008)(5660300002)(70206006)(508600001)(316002)(54906003)(70586007)(2906002)(426003)(1076003)(2616005)(336012)(82310400003)(186003)(8936002)(8676002)(6666004)(36860700001)(26005)(47076005)(83380400001)(7696005)(36756003)(6916009)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 15:41:38.4980 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cfdf221f-bc08-4c90-b4d3-08d99ee06ccf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7022 Content-Type: text/plain Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser with the Cache ID field and relevant validations as defined in tables 5.140 and 5.141 of the ACPI 6.4 specification. Signed-off-by: Chris Jones --- Notes: v2: - Fixed a bug where 'CacheFlags' and 'CacheId' were only set after the validation function had finished. Instead set them inside the validation function using the first 'Ptr' parameter. ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 120 +++++++++++++++++++- 1 file changed, 118 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c index bb840a0dbab240d371aa58d323e61f47fa8d1587..3f93038ce1d83c005ae3d6a43e11f309440ad6fa 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c @@ -20,8 +20,84 @@ STATIC CONST UINT8* ProcessorTopologyStructureType; STATIC CONST UINT8* ProcessorTopologyStructureLength; STATIC CONST UINT32* NumberOfPrivateResources; +STATIC CONST EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS* CacheFlags; STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; +/** + Increment the error count and print an error that a required flag is missing. + + @param [in] FlagName Name of the missing flag. +**/ +STATIC +VOID +EFIAPI +LogCacheFlagError ( + IN CONST CHAR16* FlagName + ) +{ + IncrementErrorCount (); + Print ( + L"\nERROR: On Arm based systems, all cache properties must be" + L"provided in the cache type structure." + L"Missing '%s' flag.", + *FlagName + ); +} + +/** + This function validates the Cache Type Structure (Type 1) Cache Flags field. + + @param [in] Ptr Pointer to the start of the field data. + @param [in] Context Pointer to context specific information e.g. this + could be a pointer to the ACPI table header. +**/ +STATIC +VOID +EFIAPI +ValidateCacheFlags ( + IN UINT8* Ptr, + IN VOID* Context + ) +{ +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64) + CacheFlags = (EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS*)Ptr; + + if (CacheFlags == NULL) { + IncrementErrorCount (); + Print (L"\nERROR: Cache Structure Flags were not successfully read."); + return; + } + + if (CacheFlags->SizePropertyValid == EFI_ACPI_6_4_PPTT_CACHE_SIZE_INVALID) { + LogCacheFlagError (L"Size Property Valid"); + } + if (CacheFlags->NumberOfSetsValid == EFI_ACPI_6_4_PPTT_NUMBER_OF_SETS_INVALID) { + LogCacheFlagError (L"Number Of Sets Valid"); + } + if (CacheFlags->AssociativityValid == EFI_ACPI_6_4_PPTT_ASSOCIATIVITY_INVALID) { + LogCacheFlagError (L"Associativity Valid"); + } + if (CacheFlags->AllocationTypeValid == EFI_ACPI_6_4_PPTT_ALLOCATION_TYPE_INVALID) { + LogCacheFlagError (L"Allocation Type Valid"); + } + if (CacheFlags->CacheTypeValid == EFI_ACPI_6_4_PPTT_CACHE_TYPE_INVALID) { + LogCacheFlagError (L"Cache Type Valid"); + } + if (CacheFlags->WritePolicyValid == EFI_ACPI_6_4_PPTT_WRITE_POLICY_INVALID) { + LogCacheFlagError (L"Write Policy Valid"); + } + if (CacheFlags->LineSizeValid == EFI_ACPI_6_4_PPTT_LINE_SIZE_INVALID) { + LogCacheFlagError (L"Line Size Valid"); + } + // Cache ID was only introduced in revision 3 + if (*(AcpiHdrInfo.Revision) >= 3) { + if (CacheFlags->CacheIdValid == EFI_ACPI_6_4_PPTT_CACHE_ID_INVALID) { + LogCacheFlagError (L"Cache Id Valid"); + } + } +#endif +} + /** This function validates the Cache Type Structure (Type 1) 'Number of sets' field. @@ -141,6 +217,44 @@ ValidateCacheLineSize ( #endif } +/** + This function validates the Cache Type Structure (Type 1) Cache ID field. + + @param [in] Ptr Pointer to the start of the field data. + @param [in] Context Pointer to context specific information e.g. this + could be a pointer to the ACPI table header. +**/ +STATIC +VOID +EFIAPI +ValidateCacheId ( + IN UINT8* Ptr, + IN VOID* Context + ) +{ + UINT32 CacheId; + CacheId = *(UINT32*)Ptr; + + // Cache ID was only introduced in revision 3 + if (*(AcpiHdrInfo.Revision) < 3) { + return; + } + + if (CacheFlags == NULL) { + IncrementErrorCount (); + Print (L"\nERROR: Cache Structure Flags were not successfully read."); + return; + } + + if (CacheFlags->CacheIdValid == EFI_ACPI_6_4_PPTT_CACHE_ID_VALID) { + if (CacheId == 0) { + IncrementErrorCount (); + Print (L"\nERROR: 0 is not a valid Cache ID."); + return; + } + } +} + /** This function validates the Cache Type Structure (Type 1) Attributes field. @@ -213,13 +327,15 @@ STATIC CONST ACPI_PARSER CacheTypeStructureParser[] = { {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL}, - {L"Flags", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Flags", 4, 4, L"0x%x", NULL, (VOID**)&CacheFlags, ValidateCacheFlags, + NULL}, {L"Next Level of Cache", 4, 8, L"0x%x", NULL, NULL, NULL, NULL}, {L"Size", 4, 12, L"0x%x", NULL, NULL, NULL, NULL}, {L"Number of sets", 4, 16, L"%d", NULL, NULL, ValidateCacheNumberOfSets, NULL}, {L"Associativity", 1, 20, L"%d", NULL, NULL, ValidateCacheAssociativity, NULL}, {L"Attributes", 1, 21, L"0x%x", NULL, NULL, ValidateCacheAttributes, NULL}, - {L"Line size", 2, 22, L"%d", NULL, NULL, ValidateCacheLineSize, NULL} + {L"Line size", 2, 22, L"%d", NULL, NULL, ValidateCacheLineSize, NULL}, + {L"Cache ID", 4, 24, L"%d", NULL, NULL, ValidateCacheId, NULL} }; /** -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")