From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web09.10068.1636022976132457507 for ; Thu, 04 Nov 2021 03:49:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=hUrXHCHE; spf=pass (domain: nuviainc.com, ip: 209.85.221.49, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f49.google.com with SMTP id r8so7872285wra.7 for ; Thu, 04 Nov 2021 03:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+oRR8D0z4hczpEMH+mZndpHNaPsCIGlaZQ+owLCMtAo=; b=hUrXHCHEN14E4n/st4bAY62bVzQGgSR3eOKzlEJVrJDJguiT8ap3244ybCO1DNL58F gsBwMmDg3Yo3ruZ1+XXfNnannBj2dBCqSSAVyBE346tw4QOR65bb4n/ZAYdT7qWpoAMk IMuQJBmjWB0E6X/427vmaK3rtcgq8hfu6QuEwHpMVIGwcv/bvilbdB9/LOao7I2oIQI0 cQFE8+s9Uy0WKlLUdmPPlE83VOu1mlYFPIV9/CkLZ7Xe0CxnpCeb7zwHtA1Vobk2341r DC/jx4DnAyVubzWyICQmjTJwZFmW09mwjAtcOyHqNFncdTqUqN9p95ktVEPYMFb3gzpG HLMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+oRR8D0z4hczpEMH+mZndpHNaPsCIGlaZQ+owLCMtAo=; b=1GRuSjzXOa+noxxKR99BSNOsFVWLdRu7bPiMY1LSEJVB0EjFZ02OVhn4TC6eW0R5+m Qa50b+uU5+Y7PkIUr1sKT9rzx5xcluSpCT5st2+PtPFVWcK5QHjCHERUBFtXZQVkIJqT dyKV/8x1r01xXVTUglwsKArgxgptUcwl5tmFne10/Ouh9QG+bS05D16jouBO45p600Sh NDJhKJWrNHvF39f5K8ar8hZKfJYQ6SwSmVG1NtH8sVymFf1vobGN9AaBh0cAZ4m+c2V1 SsblgNjjKRKEXqeGpVomI9DkFB4oxR93km54aX7EY1PeOyPi4Fb759CXb99Fkj5CVyk3 IHxg== X-Gm-Message-State: AOAM532NffCjoNGZhKFMGgFNuBmJfsmpZyYZZ0yhCRgSwFPEvXuFpQv7 jmAbotAAHuokQNmBap2LKsmlfQ== X-Google-Smtp-Source: ABdhPJy+DH9hY6XC55knuC+792prU2u2zd+lkpGIXhAaaM5BKoBL0Kky2phRDpVmaTxA9B/jJueNhg== X-Received: by 2002:a05:6000:2ae:: with SMTP id l14mr9348274wry.142.1636022974754; Thu, 04 Nov 2021 03:49:34 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id h17sm7990948wmb.44.2021.11.04.03.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Nov 2021 03:49:34 -0700 (PDT) Date: Thu, 4 Nov 2021 10:49:32 +0000 From: "Leif Lindholm" To: Michael D Kinney Cc: devel@edk2.groups.io, Bob Feng , Liming Gao , Yuwei Chen , Ard Biesheuvel Subject: Re: [Patch V2 7/7] BaseTools/Conf: Fix Linux GCC ARM build issues with HII Message-ID: <20211104104932.ud75q7wx472hoqg4@leviathan> References: <20211103225954.1680-1-michael.d.kinney@intel.com> <20211103225954.1680-8-michael.d.kinney@intel.com> MIME-Version: 1.0 In-Reply-To: <20211103225954.1680-8-michael.d.kinney@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 03, 2021 at 15:59:54 -0700, Michael D Kinney wrote: > Update builds_rules.template to add $(SLINK) to the GCC > steps for processing HII resources to produce a static > library instead of an object file. This improves linker > compatibility and specifically fixes a link failure seen > on Linux GCC ARM builds of the MdeModulePkg due to > mismatched ABI types between the HII resource section > and the rest of the libraries. > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Michael D Kinney This arguably looks like a plain fix in the first place. However, I am only able to trigger the build failure for the NOOPT target. That may be useful to mention in the commit message. With that: Reviewed-by: Leif Lindholm > --- > BaseTools/Conf/build_rule.template | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template > index 3add1029f276..5f59044da36d 100755 > --- a/BaseTools/Conf/build_rule.template > +++ b/BaseTools/Conf/build_rule.template > @@ -668,6 +668,8 @@ > > > "$(GENFW)" -o $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc -g $(MODULE_GUID) --hiibinpackage $(HII_BINARY_PACKAGES) $(GENFW_FLAGS) > - "$(RC)" $(RC_FLAGS) $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc ${dst} > + "$(RC)" $(RC_FLAGS) $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc.obj > + "$(SLINK)" cr ${dst} $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc.obj > + > > "$(GENFW)" -o $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc -g $(MODULE_GUID) --hiibinpackage $(HII_BINARY_PACKAGES) $(GENFW_FLAGS) > -- > 2.32.0.windows.1 >