From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: devel@edk2.groups.io, marcandre.lureau@redhat.com,
Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2
Date: Fri, 5 Nov 2021 13:17:27 +0100 [thread overview]
Message-ID: <20211105121727.uy6hmpkj3xg5bpc2@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211102154910.2715495-4-stefanb@linux.ibm.com>
On Tue, Nov 02, 2021 at 11:49:09AM -0400, Stefan Berger wrote:
> Enable the physical presence interface for TPM 1.2. It is required for the
> TPM 1.2 menu to work.
>
> The changes to DxeTcgPhysicalPresenceLib.c are due to the device we are using
> in QEMU for presenting the supported PPI commands and results to the OS via
> ACPI as well as to store the PPI opcode to execute.
Fails to build for microvm.
> + TcgPhysicalPresenceLib|OvmfPkg/Library/TcgPhysicalPresenceLibNull/DxeTcgPhysicalPresenceLib.inf
I guess this line is needed just next to Tcg2PhysicalPresenceLibNull
line?
(same problem on OvmfXen.dsc)
take care,
Gerd
next prev parent reply other threads:[~2021-11-05 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 15:49 [PATCH v2 0/4] Add support for TPM 1.2 Physical Presence Interface and Menu Stefan Berger
2021-11-02 15:49 ` [PATCH v2 1/4] SecurityPkg: Store physical presence code by submitting to PreOS func Stefan Berger
2021-11-02 15:49 ` [PATCH v2 2/4] OvmfPkg: Copy TPM 1.2 DxeTcgPhysicalPresenceLib.c from SecuityPkg Stefan Berger
2021-11-02 15:49 ` [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2 Stefan Berger
2021-11-05 12:17 ` Gerd Hoffmann [this message]
2021-11-07 1:19 ` [edk2-devel] " Stefan Berger
2021-11-08 11:57 ` Gerd Hoffmann
2021-11-08 12:13 ` Yao, Jiewen
2021-11-08 14:43 ` Stefan Berger
[not found] ` <16B59953A0045591.32008@groups.io>
2021-11-08 20:53 ` Stefan Berger
2021-11-02 15:49 ` [PATCH v2 4/4] OvmfPkg: add TPM 1.2 config menu Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105121727.uy6hmpkj3xg5bpc2@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox