From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.43878.1636372701897892655 for ; Mon, 08 Nov 2021 03:58:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UIA8fwtY; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636372700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wXeCvxb0YdbjrrZ8IyUp8qpZrPGnV7eEklBo7UWrxX8=; b=UIA8fwtYijKtYK8S97h/jyl0EPUX7zboB506z3J48ut83HC7h8m5f4xKtrwleqdllamahs 0yCV36oB+Q7I65H/EssPEQFtfPxZ6PIr6IhfwFp4v0OYEHcIskHsz+Et3DQf+jAl06S6WC e70HpFJYlyGZBXlaCEjd6ZD9ei/wupc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-sOgyXdCyPkyxahEz5f1qfw-1; Mon, 08 Nov 2021 06:58:15 -0500 X-MC-Unique: sOgyXdCyPkyxahEz5f1qfw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB58A804144; Mon, 8 Nov 2021 11:58:13 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B54B519C79; Mon, 8 Nov 2021 11:57:55 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2D28E1803560; Mon, 8 Nov 2021 12:57:54 +0100 (CET) Date: Mon, 8 Nov 2021 12:57:54 +0100 From: "Gerd Hoffmann" To: Stefan Berger Cc: devel@edk2.groups.io, marcandre.lureau@redhat.com, Jiewen Yao , Jian J Wang , Ard Biesheuvel , Jordan Justen Subject: Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2 Message-ID: <20211108115754.tm5cfewgrzyvptet@sirius.home.kraxel.org> References: <20211102154910.2715495-1-stefanb@linux.ibm.com> <20211102154910.2715495-4-stefanb@linux.ibm.com> <20211105121727.uy6hmpkj3xg5bpc2@sirius.home.kraxel.org> <05c7dab9-ff60-db8b-d91c-9d769c25c45f@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <05c7dab9-ff60-db8b-d91c-9d769c25c45f@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Nov 06, 2021 at 09:19:33PM -0400, Stefan Berger wrote: > > On 11/5/21 08:17, Gerd Hoffmann wrote: > > On Tue, Nov 02, 2021 at 11:49:09AM -0400, Stefan Berger wrote: > > > Enable the physical presence interface for TPM 1.2. It is required for the > > > TPM 1.2 menu to work. > > > > > > The changes to DxeTcgPhysicalPresenceLib.c are due to the device we are using > > > in QEMU for presenting the supported PPI commands and results to the OS via > > > ACPI as well as to store the PPI opcode to execute. > > Fails to build for microvm. > > > > > + TcgPhysicalPresenceLib|OvmfPkg/Library/TcgPhysicalPresenceLibNull/DxeTcgPhysicalPresenceLib.inf > > I guess this line is needed just next to Tcg2PhysicalPresenceLibNull > > line? > > (same problem on OvmfXen.dsc) > > Fixed in v3 for microvm and Xen and Bhyve also. > > You happen to know about the variable lock issue? Why does the variable need > to be locked? No clue, sorry. That's a topic I have to learn about myself. Noticed the variable locking deprecation warning in the ovmf boot log too, but havn't found the time yet to look into that. take care, Gerd