public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe
Date: Tue, 9 Nov 2021 07:59:46 +0100	[thread overview]
Message-ID: <20211109065946.ndeg4sloapkfgvz7@sirius.home.kraxel.org> (raw)
In-Reply-To: <cover.1636350203.git.min.m.xu@intel.com>

On Mon, Nov 08, 2021 at 02:07:57PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
> 
> XenTimerDxe is a local Apic timer driver and it has nothing to do
> with Xen. So rename it to LocalApicTimerDxe.
> 
> After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.
> Otherwise 8254 timer is used.
> 
> Since LocalApicTimerDxe doesn't depend on OvmfPkg, so it is moved to
> UefiCpuPkg.
> 
> Patch #1:
> Rename XenTimerDxe to LocalApicTimerDxe
> 
> Patch #2:
> Switch timer in build time for OvmfPkg. If CSM_ENABLE=TRUE, 8254 timer
> is used, otherwise the timer is LocalApicTimerDxe.
> 
> Patch #3:
> Move LocalApicTimerDxe from OvmfPkg to UefiCpuPkg.
> 
> Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v3
> 
> v3 changes:
>  - Move LocalApicTimerDxe to UefiCpuPkg
>  - Fix the errors in v2 patch-1 that OvmfXen.dsc / .fdf and
>    MicrovmX64.dsc / .fdf are not updated for new name.
>  - Add XenTimerDxe reviewers.
> 
> v2 changes:
>  - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>


  parent reply	other threads:[~2021-11-09  6:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08  6:07 [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe Min Xu
2021-11-08  6:07 ` [PATCH V3 1/3] OvmfPkg: " Min Xu
2021-11-11 14:46   ` Anthony PERARD
2021-11-08  6:07 ` [PATCH V3 2/3] OvmfPkg: Switch timer in build time for OvmfPkg Min Xu
2021-11-08  6:08 ` [PATCH V3 3/3] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg Min Xu
2021-11-11 14:47   ` Anthony PERARD
2021-11-22  3:04   ` Ni, Ray
2021-11-22  3:34     ` Yao, Jiewen
2021-11-23  8:24     ` Min Xu
2021-11-23  9:45       ` Gerd Hoffmann
2021-11-09  6:59 ` Gerd Hoffmann [this message]
2021-11-09  7:03   ` [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211109065946.ndeg4sloapkfgvz7@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox