From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.8827.1636441198775039549 for ; Mon, 08 Nov 2021 22:59:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CsOoEZle; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636441197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z64aBEwdQSRpb9gSNkYb2CC5YH/fEEXEAkoagb6Ro08=; b=CsOoEZlew8p9Xh9FV7NlR0pd3rTQ6ZJa9933oD/njV3HYKYsmbxsSJdZq7eJg//9rPdouh yZi8Vpwus14KiME4yMfuDf7Xjjx7TxRVOrE3yEcWkJJ4UxPtGU6N20/2bzNQ6W5SupB5JI hfeV9ILpuSXWeBp7Li3VzMvt6xHTlnY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-eZGf96j4MtqeWTWNyfiWhg-1; Tue, 09 Nov 2021 01:59:51 -0500 X-MC-Unique: eZGf96j4MtqeWTWNyfiWhg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0829B1030C22; Tue, 9 Nov 2021 06:59:50 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EB6E1017E37; Tue, 9 Nov 2021 06:59:49 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 50976180A429; Tue, 9 Nov 2021 07:59:46 +0100 (CET) Date: Tue, 9 Nov 2021 07:59:46 +0100 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Eric Dong , Ray Ni Subject: Re: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe Message-ID: <20211109065946.ndeg4sloapkfgvz7@sirius.home.kraxel.org> References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 08, 2021 at 02:07:57PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > XenTimerDxe is a local Apic timer driver and it has nothing to do > with Xen. So rename it to LocalApicTimerDxe. > > After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE. > Otherwise 8254 timer is used. > > Since LocalApicTimerDxe doesn't depend on OvmfPkg, so it is moved to > UefiCpuPkg. > > Patch #1: > Rename XenTimerDxe to LocalApicTimerDxe > > Patch #2: > Switch timer in build time for OvmfPkg. If CSM_ENABLE=TRUE, 8254 timer > is used, otherwise the timer is LocalApicTimerDxe. > > Patch #3: > Move LocalApicTimerDxe from OvmfPkg to UefiCpuPkg. > > Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v3 > > v3 changes: > - Move LocalApicTimerDxe to UefiCpuPkg > - Fix the errors in v2 patch-1 that OvmfXen.dsc / .fdf and > MicrovmX64.dsc / .fdf are not updated for new name. > - Add XenTimerDxe reviewers. > > v2 changes: > - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Cc: Eric Dong > Cc: Ray Ni > Signed-off-by: Min Xu Reviewed-by: Gerd Hoffmann