From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.9456.1636447211184317135 for ; Tue, 09 Nov 2021 00:40:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gAgdyDuY; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636447209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NENjKSF6D3kgoks+j23HKxbR1g4//BSV6FNOTNFxXSY=; b=gAgdyDuYgus+jCg3t2AuQeqcO1JRz0DyiiKHYKzioGGjnmfpXcfMOevF299kTuaDp76mBe qJ/xpm/oBaI2zDAwSAsBI+29ov93cu1KRInwZpRWXhZs6we3PFDKbxUVFuJfaXthdZzymf dJWbc2rTZpy53jzLnJqCq7K83LLAgKo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-lW0kjHnEOHS50mP8SpNwQw-1; Tue, 09 Nov 2021 03:40:06 -0500 X-MC-Unique: lW0kjHnEOHS50mP8SpNwQw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD4F183DC17; Tue, 9 Nov 2021 08:40:04 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3425460BE5; Tue, 9 Nov 2021 08:40:04 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4D6D2180A429; Tue, 9 Nov 2021 09:40:02 +0100 (CET) Date: Tue, 9 Nov 2021 09:40:02 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Andrew Fish , Marvin =?utf-8?Q?H=C3=A4user?= , Michael Kubacki , Leif Lindholm , "mikuback@linux.microsoft.com" , "rebecca@nuviainc.com" , Bret Barkelew Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? Message-ID: <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org> References: <07a6ecff-f7bf-083a-f24d-246ca6c7988b@nuviainc.com> <2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de> <9fe0f984-db9d-9aec-0b44-5d30791a2855@linux.microsoft.com> <20211007104813.wa4rmfsqgcpvnzwt@leviathan> <07d5c8bc-40b2-4e99-3b3d-4c8ac4e14220@posteo.de> <438B4D66-2CFB-45E3-AF75-42342F0B1E67@apple.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > 3. Require use of uncrustify tool before submitting patch review emails or PRs. > * The required version would be a formally released version from the fork maintained by Michael Kubacki until the changes can be upstreamed. > * https://dev.azure.com/projectmu/Uncrustify Can we please *first* get the changes merged to upstream uncrustify? That'll make the whole process much less painful because the usual software repositories (linux distro packages, macos homebrew, ...) can be used to install uncrustify then, and it's also less confusing if developers don't have to juggle with different uncrustify variants (upstream vs. edk2). thanks, Gerd