From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.groups.io with SMTP id smtpd.web10.11232.1636461394173142594 for ; Tue, 09 Nov 2021 04:36:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=g7meA5lN; spf=pass (domain: nuviainc.com, ip: 209.85.221.50, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f50.google.com with SMTP id n29so20993759wra.11 for ; Tue, 09 Nov 2021 04:36:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Esxuml5xz+Z4yuoLY2/w7og2nQ6Zz9vXmZdOWz0iuBY=; b=g7meA5lNBW/sMZOcs2HhTxVVjVpVhf9uPuMI/X7BNRGRHQ//yyNEj9hOg4E/iAEx0k 3Z77Z8Xy8pEpBeG9dj7KvbTylrzZz/EDVrxjDU7eBcO9T+ubBa/e/vXKMNeEiLDfqf/I 5yUQZOqfc7rYMjBcfV0WWLCeNEJfxr6fQG4+GQ3g9PGzMvGUqM6bI79kaFwm1kkrFG0i tMNvFmcnG/sfTTq4Nxx9bAVCGI5kJ5KQ4rH+rS67ZP2d9lBl+lY7FYcNwNc+JQnu0ALL oc3LostMQsm0qOKmY1OnAADwBCsTkl28SOnN8RKqg5glNhSrsPDyEyo5Pp5fmz4v9yl1 iW1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Esxuml5xz+Z4yuoLY2/w7og2nQ6Zz9vXmZdOWz0iuBY=; b=qhzBFVPqC9dF65t7Ek/OuFCruEJZCFC/KQ+If2pSdxv2IsB09b8piRD3Xlm/hhrfFx YMUnwpJLVbYKptmrUoF6BFql1+9xBVMIH7/9jWZJfyNhmvLla0YpK81FXFFcbaumSCxT HwiDpQ76G7dk/wXdIQAAcHvq80fOm2+G3sB/xDkpgxU9N6HB6m5uqZjSpaN5/MFgg50p RKLEHjDB5CeHLiT7SC5DJsu5VWW+LCsI5O384w3PXP/askumpNJwUQlAyh4mKpaSXLTK Adu5eKig2cmytL8cNns9+tyJNqSBUnH9kQ8MWDUhxwtODbxAI9sFQNrOBSCw0qLVtOOU nw0A== X-Gm-Message-State: AOAM532wIy0q4R4Zbdz3LH7PBUtam+mywx8xS1/uNc2Zr5C6ufQhbbu7 X2odGJCloh/jP5FwzWfOuosBfg== X-Google-Smtp-Source: ABdhPJwNrq63739bf4LO4GUzzkRiCIgoqpc0N0cD/HnC0A87QphOOBz4qhi9D9izbHVmk8IJYVO9rQ== X-Received: by 2002:a05:6000:168f:: with SMTP id y15mr8876923wrd.61.1636461392722; Tue, 09 Nov 2021 04:36:32 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id h13sm20389840wrx.82.2021.11.09.04.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 04:36:32 -0800 (PST) Date: Tue, 9 Nov 2021 12:36:30 +0000 From: "Leif Lindholm" To: Gerd Hoffmann Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, Andrew Fish , Marvin =?utf-8?Q?H=C3=A4user?= , Michael Kubacki , "mikuback@linux.microsoft.com" , "rebecca@nuviainc.com" , Bret Barkelew Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? Message-ID: <20211109123630.j7ropheao337m7rf@leviathan> References: <2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de> <9fe0f984-db9d-9aec-0b44-5d30791a2855@linux.microsoft.com> <20211007104813.wa4rmfsqgcpvnzwt@leviathan> <07d5c8bc-40b2-4e99-3b3d-4c8ac4e14220@posteo.de> <438B4D66-2CFB-45E3-AF75-42342F0B1E67@apple.com> <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote: > Hi, > > > 3. Require use of uncrustify tool before submitting patch review emails or PRs. > > * The required version would be a formally released version from the fork maintained by Michael Kubacki until the changes can be upstreamed. > > * https://dev.azure.com/projectmu/Uncrustify > > Can we please *first* get the changes merged to upstream uncrustify? > > That'll make the whole process much less painful because the usual > software repositories (linux distro packages, macos homebrew, ...) > can be used to install uncrustify then, and it's also less confusing if > developers don't have to juggle with different uncrustify variants > (upstream vs. edk2). Whilst I agree in principle... This means postponing automated coding style changes until 2023 (Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later ... and I'd rather not. I like Marvin's suggestion of a submodule. Which we could drop once no longer needed. / Leif