From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.13470.1636471617824754761 for ; Tue, 09 Nov 2021 07:26:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UoapHsL/; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636471617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IRYIupBgoQ4t/6TMJfSanrO9lwn274ktw4HK8gAVYi0=; b=UoapHsL/8Ff/tt6yB01X7z9Xv7R1/lukWoxH3Aj7urZXT92YxDA9vm7MVN9J+M5rQdTbyT JstufAAESR4NSTfm3mcALGW67ipR/eO5XTjdAGIPIeLZXzjwLlylQq1Aow+YGyNiwPChdw KYOCNpA4sTVAqa6ZGD0cm0VB66H6BIM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-T4ZiKXUUNVSE52gKe6kdMw-1; Tue, 09 Nov 2021 10:26:52 -0500 X-MC-Unique: T4ZiKXUUNVSE52gKe6kdMw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97339180830B; Tue, 9 Nov 2021 15:26:50 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.245]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E05387086C; Tue, 9 Nov 2021 15:26:49 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E1E371800D65; Tue, 9 Nov 2021 15:10:07 +0100 (CET) Date: Tue, 9 Nov 2021 15:10:07 +0100 From: "Gerd Hoffmann" To: Leif Lindholm Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, Andrew Fish , Marvin =?utf-8?Q?H=C3=A4user?= , Michael Kubacki , "mikuback@linux.microsoft.com" , "rebecca@nuviainc.com" , Bret Barkelew Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? Message-ID: <20211109141007.z5iqvrspuqfleqzj@sirius.home.kraxel.org> References: <9fe0f984-db9d-9aec-0b44-5d30791a2855@linux.microsoft.com> <20211007104813.wa4rmfsqgcpvnzwt@leviathan> <07d5c8bc-40b2-4e99-3b3d-4c8ac4e14220@posteo.de> <438B4D66-2CFB-45E3-AF75-42342F0B1E67@apple.com> <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org> <20211109123630.j7ropheao337m7rf@leviathan> MIME-Version: 1.0 In-Reply-To: <20211109123630.j7ropheao337m7rf@leviathan> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 09, 2021 at 12:36:30PM +0000, Leif Lindholm wrote: > On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > 3. Require use of uncrustify tool before submitting patch review emails or PRs. > > > * The required version would be a formally released version from the fork maintained by Michael Kubacki until the changes can be upstreamed. > > > * https://dev.azure.com/projectmu/Uncrustify > > > > Can we please *first* get the changes merged to upstream uncrustify? > > > > That'll make the whole process much less painful because the usual > > software repositories (linux distro packages, macos homebrew, ...) > > can be used to install uncrustify then, and it's also less confusing if > > developers don't have to juggle with different uncrustify variants > > (upstream vs. edk2). > > Whilst I agree in principle... > > This means postponing automated coding style changes until 2023 > (Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later > ... and I'd rather not. > > I like Marvin's suggestion of a submodule. Which we could drop once > no longer needed. I'm fine with a submodule (temporary & optional) so we don't have to wait until all distros (especially the LTS ones which are slower) have picked up the latest uncrustify release. But I still think upstreaming the uncrustify changes should be the first step. take care, Gerd