From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web10.2684.1636491357852262434 for ; Tue, 09 Nov 2021 12:55:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=jCX8A5em; spf=pass (domain: nuviainc.com, ip: 209.85.128.53, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f53.google.com with SMTP id r9-20020a7bc089000000b00332f4abf43fso2434363wmh.0 for ; Tue, 09 Nov 2021 12:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K1jPYnhWsKY+xAcyRexU3L0deZejkV4jCXsvk+xAwks=; b=jCX8A5emRVQh+PCeVVwWV0APqwwqyWI0gfmGZbanjAwfJ2458Vop2nHTOD2HxIAfz2 ggBtduZi+jANU/RdWeJwKyzJPYc+Af4gxXrO9A/BdM8y6L/WlgSzYR3cEdo2PbWsRMge NKT2RugBW1x1EH6QHH9ITgyt5DJzuLOW1v8Hyk09Rtgxvjjm1B83gIJ82HynRxmuqEo0 MGOpVgPnQm72AYb1ugIzp1hV/MW7VaCuNRLN31N93+0Zu6mYL822tSwYw/f72HLmIwNK awhMCSXOadIDFFetLHBpWR8efTq1zbT07mLi6S5WJ/om/XdZn0HWnTuroD6DEbLBjgsj s+Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K1jPYnhWsKY+xAcyRexU3L0deZejkV4jCXsvk+xAwks=; b=gquEk8dbHl7ozS5CEVH6KPFv8a4EPOhb0umcTwBCDo7PGMZ1P2lx4ENiVWa9xK+C61 dzSBOcXNMv1EWowY0/ljw2WGrFYkWuIuSb1NQ6TQ53LMtg4mUZ5+0tUZHM6KLBnCZoCY L4yIWxfPDB7e67+m6tdhnI3LXJxkeUtVS2TnLeOZr5X1m5eDY0269sjfT3BdsMPSblgs 54DZ41ypWuoAGj5QcVZ/7Y/KCNfmL+z6Axp4f7qwr5NBDM8SGx1LCg2rRnDPv3l+0w6K BHyYsyOTkLR18PGKItetN4XsKAdr/OTAKbSmpLjba/u+/d+lUBsk1JQJ46J2qz46Q61s hkgg== X-Gm-Message-State: AOAM532vgAuuTptwTy0JsEhgTYjK7UhXvpCMdfndVK0CcddxEO5smZdC vayRPdN1EFIwHLcYAZBQraKm5cWRVY5a4Gv/DnHFaYxY8vVltgiwOeanRMnBzcPLzhDSjJpZJmO bMooCYzDgQIZ0zSyMQLWGJar7nhYPVKGp3BhWXkPIlOuckda3Zgv9HAoS27DgjJ93aPIx X-Google-Smtp-Source: ABdhPJyIQEyarxYJqJcAEykrCr1w+dz19nnGQKk3hQEbXCEMHuE/ct/cKhOtArJWf1W8vSQCKPzxaA== X-Received: by 2002:a05:600c:2118:: with SMTP id u24mr10500730wml.0.1636491355907; Tue, 09 Nov 2021 12:55:55 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id g5sm24455901wri.45.2021.11.09.12.55.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 12:55:55 -0800 (PST) Date: Tue, 9 Nov 2021 20:55:52 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Marvin =?utf-8?Q?H=C3=A4user?= , Andrew Fish , Michael Kubacki , "mikuback@linux.microsoft.com" , "rebecca@nuviainc.com" , Bret Barkelew Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? Message-ID: <20211109205552.vhihtaunrlc36eos@leviathan> References: <07F39C4E-DA8E-4650-A48B-66DA2E08314B@apple.com> <7e579772-2a21-aaf5-26cc-faed0a1950e1@posteo.de> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Mike, On Tue, Nov 09, 2021 at 16:33:31 +0000, Michael D Kinney wrote: > > >> 1. If virtually everyone will need Uncrustify, why cannot it be built along with BaseTools from a submodule? Especially > > >> with the fork that makes sense, after that it depends on the upstream (it does not look too nice to me). > > > No matter where uncrustify sources are hosted, developers can always choose to build the uncrustify tool locally. > > > Providing release binaries for the tool may be simpler for some customers. > > > Using release binaries from EDK II CI agents will reduce CI execution time. > > > > My point was it'd be nice if it (optionally) "just worked", so > > Uncrustify could be be built as part of the edk2 BaseTools build > > process, or release binaries could be downloaded by some script, or > > whatever really. I guess it could be the same logic as for the CI? > > Setting up a development work environment also requires the installation of tools such as > compilers, NASM, IASL, etc. These are not handled as part of BaseTools today. No, but users are not required to install a specific, not-yet-upstream version of a tool. This is the fundamental problem here. Once the edk2 support is available in upstream uncrustify, there is a substantial lag in how the updated version trickles down through packaging systems. > Supporting this indent style is one of the enhancements in the fork. If we want to align > to one of the indent styles supported by a wider array of source editors/IDEs, then that > would require a change to the EDK II Coding Style Specification and approval from the > EDK II community. Yes. The above problem of getting the tool at the appropriate version is why I previously stated my preference as being to change to coding style so it matched what was already supported in upstream uncrustify. Adding a version of the tool as a submodule of BaseTools would be a mitigation for the 5-year window introduced by *depending* on not-yet-upstream support in a commonly used tool. > > 6) Allow static function declarations. > > I agree that static functions should be allowed. Please add any comments you have to > the following Bugzilla. If you have ideas on the specific spec updates required, then > please provide a patch against the spec markdown. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1766 I think that's a different issue, but otherwise agreed. / Leif