From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web12.4519.1636500223152035081 for ; Tue, 09 Nov 2021 15:23:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=4EiN/gsA; spf=pass (domain: nuviainc.com, ip: 209.85.128.53, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f53.google.com with SMTP id v127so551435wme.5 for ; Tue, 09 Nov 2021 15:23:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7r++KlwseLI296AVXQ0j+Hv3eSeIS1uF4h8C6S/QYv8=; b=4EiN/gsAEWC/bBhk6gETqQl3eX2EW8WZ3Tr+ELBoXK9jI52qkpJ6oZK1r1pMs2VFbt J70LQHbhLZjIARgyhuvtAlludbC3uGJ1bEpRCgh62lOwBrpHqAU2RUYfxylFFuYYFcR4 hQVGMR1wmS37njVtaO8rc0ibAsKacdaIsJec12PQWR1FXOUT1Iob9Wk2kIJiI0HVhR+D zazzlwPpZD/tWF+dmZf5g+bUVeM7DjmA5OFXshlTM9leIMbu+xMUvf8YaQl6b7gcnPBi hsIotP4A8irpOZFrpY3cuLahZTrgH9MvRdiO1kJ4JiURHESQKid5xEawt4M44uSnAk1M 4WJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7r++KlwseLI296AVXQ0j+Hv3eSeIS1uF4h8C6S/QYv8=; b=GrKAE26AHe4+W1yRwRtsd+LSj9BgwcXLxWYwZ5ySf9GK3Oxi/c2RW84wjNoDrs9fPJ BGb0YHuvjbi1DSbhAwbIjkH8MKPpsGxTqFCYi24QVIT+EjCEfPCEicI6eMAGdG7JOj4Q +SeG0nZ/5CuImuHLdaaULAeKWmWiKZuCCgZh0S6bw9qGTvgg4rbdJLz6ybJbICTu9+4k WN5WUSHUcvsvd4jSkw8oz/vkX/CHCAdXe6Kl2bl9KyRJDGMfi2mYe/IfaPaB5oqrcwy6 FIHzElU196z3X8Wl0GfOEUB5zrAdYkTp4QZD5uNuVKbitTpM/GE4RY6qCbaro/viNih+ ej8g== X-Gm-Message-State: AOAM532QnjYy3hM7ctwQHKJbu7w5kbFHslNMFVZtYqvzu5FpGL3r93CH kL/heE8glUBKB7vk1HRZaD7/6Ge+ueOwGGT4beRYan6z1bJZGDzxWNTYgFMGzem1wfK9vxy6pPJ 8OILmITFnshZaSmJRMtnC1UNLoBNcHILng4RCA5AV/2eRt/E+nAVapDRJCBqrm1c1Fvzg X-Google-Smtp-Source: ABdhPJxOoA9oLbMmylYwCd4JOFZdLk8uN12pEsa+rW8QuhSHdABKm+K4FRl1KIWhqxZKkvCT8K9fZA== X-Received: by 2002:a7b:cf0f:: with SMTP id l15mr11668634wmg.92.1636500221247; Tue, 09 Nov 2021 15:23:41 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id m34sm4164191wms.25.2021.11.09.15.23.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 15:23:40 -0800 (PST) Date: Tue, 9 Nov 2021 23:23:38 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Marvin =?utf-8?Q?H=C3=A4user?= , Andrew Fish , Michael Kubacki , "mikuback@linux.microsoft.com" , "rebecca@nuviainc.com" , Bret Barkelew Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? Message-ID: <20211109232338.z6qb5kk7yz3mc2em@leviathan> References: <07F39C4E-DA8E-4650-A48B-66DA2E08314B@apple.com> <7e579772-2a21-aaf5-26cc-faed0a1950e1@posteo.de> <20211109205552.vhihtaunrlc36eos@leviathan> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 09, 2021 at 21:20:51 +0000, Michael D Kinney wrote: > > > Setting up a development work environment also requires the installation of tools such as > > > compilers, NASM, IASL, etc. These are not handled as part of BaseTools today. > > > > No, but users are not required to install a specific, not-yet-upstream > > version of a tool. This is the fundamental problem here. > > > > Once the edk2 support is available in upstream uncrustify, there is a > > substantial lag in how the updated version trickles down through > > packaging systems. > > There is an RFC with no negative feedback to move to NASM 2.15.05. > > I do not believe that is the version supported in all the distros > packaging systems yet. It is in current Debian stable. It is *not* in Ubuntu LTS. > So I expect there will likely be many windows of time where the > EDK II projects have a dependency on a tool in that state. > > If this was a significant concern, why was it not raised with the > NASM 2.15.05? I might have raised it if I had been actively tracking NASM usage, but I'll confess I don't. But even then - that is talking about NASM 2.15.05, released August 2020, not NASM HEAD today with some additional patches. > > > Supporting this indent style is one of the enhancements in the fork. If we want to align > > > to one of the indent styles supported by a wider array of source editors/IDEs, then that > > > would require a change to the EDK II Coding Style Specification and approval from the > > > EDK II community. > > > > Yes. The above problem of getting the tool at the appropriate version > > is why I previously stated my preference as being to change to coding > > style so it matched what was already supported in upstream uncrustify. > > Stating a preference without specific details on the exact style that is > actionable by developers and verifiable does not help close on this > topic. The preference was raised here only as the alternative to requiring uncrustify modifications. I stated the delta (with specific details) in my email on 7 October, and yes, you responeded to that, but no one else seemed interested in that path, so I didn't follow up. > Can you provide the specific details and update the BZs provided in an > earlier version of this thread: > > https://edk2.groups.io/g/devel/message/81609 > > If you are not able to provide details, but are rejecting this proposal all > together, then please be clear that you are rejecting the proposal so those > that are working on it can move on to other priorities. As per above. / Leif