From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.10110.1636539181938694452
 for <devel@edk2.groups.io>;
 Wed, 10 Nov 2021 02:13:02 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JcCMWAk6;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1636539180;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Q0PzKO6CdPri6ePINimJukBpisIpGzyr8LWAIUNC3pw=;
	b=JcCMWAk6P4i4dc9m2BHKOMPLXtt8QaNEBnlM+BMJreAdF+uwmj1hK2JbaUKTF2nlS71ReV
	zO2j8htK0gopc/3AO8/NlScOvmXeOlNeHsLb8Wl1lBHZvpazYXzEa0l8FiDjPT182uxEKJ
	mDBkQRluYLPHq8/detAqeD+IahQJz8g=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-561-EbxPG3cwOd29eAkLw477ug-1; Wed, 10 Nov 2021 05:12:55 -0500
X-MC-Unique: EbxPG3cwOd29eAkLw477ug-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55649BAF83;
	Wed, 10 Nov 2021 10:12:53 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.245])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id DF84A5BB06;
	Wed, 10 Nov 2021 10:12:51 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 0A1A81800936; Wed, 10 Nov 2021 11:12:50 +0100 (CET)
Date: Wed, 10 Nov 2021 11:12:50 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, mhaeuser@posteo.de
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Andrew Fish <afish@apple.com>,
	Michael Kubacki <Michael.Kubacki@microsoft.com>,
	Leif Lindholm <leif@nuviainc.com>,
	"mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
	"rebecca@nuviainc.com" <rebecca@nuviainc.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?
Message-ID: <20211110101250.khqunyhrbjfhlxnj@sirius.home.kraxel.org>
References: <e6010420-ae82-942f-e4c7-03f129f56b5d@posteo.de>
 <AB3E469F-C0D5-47DF-98FF-80D6042E86C2@apple.com>
 <CO1PR11MB49293E3C6AE64B5C02BB4963D2929@CO1PR11MB4929.namprd11.prod.outlook.com>
 <B7604E4E-AA53-4455-8905-263410A70A3E@apple.com>
 <CO1PR11MB4929DDF632645AFC8DAB922AD2929@CO1PR11MB4929.namprd11.prod.outlook.com>
 <07F39C4E-DA8E-4650-A48B-66DA2E08314B@apple.com>
 <SA2PR11MB4938EE810C357C404FF83B0AD2929@SA2PR11MB4938.namprd11.prod.outlook.com>
 <cd1c4a57-7d91-4127-b571-9c70b354c214@posteo.de>
 <CO1PR11MB49295D76820D2F1DB1D9E374D2929@CO1PR11MB4929.namprd11.prod.outlook.com>
 <7e579772-2a21-aaf5-26cc-faed0a1950e1@posteo.de>
MIME-Version: 1.0
In-Reply-To: <7e579772-2a21-aaf5-26cc-faed0a1950e1@posteo.de>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

> 5) Indent relative to the last indentation, not to symbol names, i.e.
> 
>   Status = Function (
>     A
>     );
> 
> instead of
> 
>   Status = Function (
>                    A
>                    );
> 
> Uncrustify might support this now, but I have never seen even a single IDE
> that does. It'd be kind of awkward to always write "style-broken" code and
> rely on the external tool to fix it.

IDEs typically use the parentheses for that, so this style ...

    Status = Function
        (A,
         B,
         C,
         );

... might work better in IDEs.

take care,
  Gerd