From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by mx.groups.io with SMTP id smtpd.web10.7469.1636613877374283628 for ; Wed, 10 Nov 2021 22:57:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WoxIBDrD; spf=pass (domain: gmail.com, ip: 209.85.167.173, mailfrom: lintonrjeremy@gmail.com) Received: by mail-oi1-f173.google.com with SMTP id q25so4392637oiw.0 for ; Wed, 10 Nov 2021 22:57:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=06Uus9lbhi5gfmtH661zk/17Gbo+8fiSoUt93/4jczo=; b=WoxIBDrDgKtVS1e7KdQ4IHd7nAJG8UKV/bqIO/WvEDo5v6VU9F55843dmkcEpRVDpT yFFbnWHJ5A3LiUgJnTqMUmcBnSWArkFJkq1miq7NKjZiL+7ldKsMu5TSzxOUdu9hXMKS uQvygdZg7TFtxK+o6dPBSWvsLte5TQoOBizVc0oV1MqWSzRylPPOfFCO3er7oa/xrXKM z0BETBJWYEuTkuMIWMhSWiTFHPDkU9KIlDPgOU7lGMDo/2FMck/VjXj9+xPmRB/AifWJ DvNZKuNPVGWNBv45PWmdYVkM2BMJogh0TIjoaQ9fPZGA0E7ElWJCe9wU5n1LsQyDtPt7 I/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=06Uus9lbhi5gfmtH661zk/17Gbo+8fiSoUt93/4jczo=; b=FtVt6Xml2OQC9xzZmZpxSQK25ugN6jEWtzS2o9fcE7DbdMQCSVa0KhPWAPThFmFFML Fuo/CFba7G0g40EBC3rjrs/rcHBOUq0bUy98Mx1wkngFSRrZegKO+4xtCGaSqcGbpyfR gE+iZdVrvk/14xicnvIqKRA7lHNixYE0ZK/NMzSdWjf09+/TCr09omJ3wrRNSLK0SshH OxDZIyXx9gkdgUpyViDYfnagv1zmC+gulAgSjhF9mjeA3zK2BCq/caUX2bcludUsd/E9 5oi9UYQLn2NeXA0nRGGZKK5u8gHIdkDKu4jHaAfqdVdBCUxFSXnw0EFV7Dqhm1Qy7tvy wE3A== X-Gm-Message-State: AOAM530/HD3xjcMN+U6oAKfklVyPXpC8RgcxA9/O542b+EjKWbElE8QC HsLUiIbVhi0azAvqK3JNS+S1m+N1YZzJ9A== X-Google-Smtp-Source: ABdhPJwzuQ7bsvKn6tspCbTRZ14k2pia7SV8TEXxijv5kKAdMYEcYSRpUt2GBGenR8GbPMJvGWfPmg== X-Received: by 2002:aca:58d6:: with SMTP id m205mr18354471oib.126.1636613876352; Wed, 10 Nov 2021 22:57:56 -0800 (PST) Return-Path: Received: from dell-suse.jhome.net (072-191-152-022.res.spectrum.com. [72.191.152.22]) by smtp.gmail.com with ESMTPSA id y12sm649206oiv.49.2021.11.10.22.57.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Nov 2021 22:57:55 -0800 (PST) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: pete@akeo.ie, ardb+tianocore@kernel.org, leif@nuviainc.com, awarkentin@vmware.com, Sunny.Wang@arm.com, samer.el-haj-mahmoud@arm.com, Jeremy Linton Subject: [PATCH 1/4] Platform/RaspberryPi: Cleanup menu visibility Date: Thu, 11 Nov 2021 00:57:39 -0600 Message-Id: <20211111065742.8923-3-lintonrjeremy@gmail.com> X-Mailer: git-send-email 2.13.7 In-Reply-To: <20211111065742.8923-1-lintonrjeremy@gmail.com> References: <20211111065742.8923-1-lintonrjeremy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr index e8bf16312d..f668b7a553 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr @@ -196,7 +196,7 @@ formset endoneof; #if (RPI_MODEL == 4) - grayoutif NOT ideqval SystemTableMode.Mode == SYSTEM_TABLE_MODE_ACPI; + grayoutif ideqval SystemTableMode.Mode == SYSTEM_TABLE_MODE_DT; oneof varid = FanOnGpio.Enabled, prompt = STRING_TOKEN(STR_ADVANCED_FANONGPIO_PROMPT), help = STRING_TOKEN(STR_ADVANCED_FANONGPIO_HELP), @@ -207,7 +207,7 @@ formset endoneof; endif; - grayoutif ideqval FanOnGpio.Enabled == 0; + grayoutif ideqval FanOnGpio.Enabled == 0 OR ideqval SystemTableMode.Mode == SYSTEM_TABLE_MODE_DT; numeric varid = FanTemp.Value, prompt = STRING_TOKEN(STR_ADVANCED_FANTEMP_PROMPT), help = STRING_TOKEN(STR_ADVANCED_FANTEMP_HELP), @@ -219,7 +219,7 @@ formset endif; suppressif ideqval XhciPci.Value == 2; - grayoutif NOT ideqval SystemTableMode.Mode == SYSTEM_TABLE_MODE_ACPI; + grayoutif ideqval SystemTableMode.Mode == SYSTEM_TABLE_MODE_DT; oneof varid = XhciPci.Value, prompt = STRING_TOKEN(STR_ADVANCED_XHCIPCI_PROMPT), help = STRING_TOKEN(STR_ADVANCED_XHCIPCI_HELP), -- 2.13.7