From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by mx.groups.io with SMTP id smtpd.web08.1870.1636648397015857721 for ; Thu, 11 Nov 2021 08:33:17 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@canonical.com header.s=20210705 header.b=O0GqqWqn; spf=pass (domain: canonical.com, ip: 185.125.188.120, mailfrom: heinrich.schuchardt@canonical.com) Received: from workstation5.fritz.box (ip-88-152-144-157.hsi03.unitymediagroup.de [88.152.144.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 5E8F23F216; Thu, 11 Nov 2021 16:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1636648394; bh=K+oeKKoIGWZ67Q6pbsJ/vTjU31Np/V2YaVHO7Xl6Xmg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=O0GqqWqnvCSYPNOWzZw6zfnsuKBaXegyBSirJFtq2NUczkDooC6NL6+x7d+h8DY24 uyaLrVYhWHrilK4DiH0rUgLUs7RMaPAcOGMPUFdJdKz2unr9MdBWq0r24W8wMzt3aS c5kyVG1hA1kxXrRQdaR9gpn5NDqVYI7kpUfiBLV2yr5WqJyX1AXVKbcl2ZwwK97CuW KZTfQw617ToyAP1Ucrr6KNZONJZq/QcN1m7Mi6I7hv8tgzvUCIb/VCFH/0our7k0DL K2Cs36PM8q+MRDN9ZjYa4bITy3zSg/zfc4oRDfhHKvnvU8IuzhNZs29cZx3/05AIhj 2jpHwKLjgL9VQ== From: Heinrich Schuchardt To: EDK II Development Cc: Eric Jin , G Edhaya Chandran , Barton Gao , Arvin Chen , Samer El-Haj-Mahmoud , Heinrich Schuchardt Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: invalid values for SetWakeupTime() Date: Thu, 11 Nov 2021 17:32:33 +0100 Message-Id: <20211111163233.83714-1-heinrich.schuchardt@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2529 According to the UEFI specification EFI_TIME.YEAR may take values in the range 1900-9999. The specification does not forbid to set a wakeup time i= n the past. We should not expect EFI_INVALID_PARAMETER to be returned by SetWakeupTime() for the years 1997 and 2100. Values 1899 and 10000 must lead to this error code. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/TimeServicesBBTestConformance.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TimeServic= es/BlackBoxTest/TimeServicesBBTestConformance.c b/uefi-sct/SctPkg/TestCas= e/UEFI/EFI/RuntimeServices/TimeServices/BlackBoxTest/TimeServicesBBTestCo= nformance.c index fcc79548c07d..bdb150d02ea3 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TimeServices/Blac= kBoxTest/TimeServicesBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TimeServices/Blac= kBoxTest/TimeServicesBBTestConformance.c @@ -817,7 +817,7 @@ BBTestSetWakeupTimeConsistencyTest ( ); } else { Time =3D OldTime; - Time.Year =3D 1997; + Time.Year =3D 1899; Status =3D gtRT->SetWakeupTime ( TRUE, &Time @@ -844,7 +844,7 @@ BBTestSetWakeupTimeConsistencyTest ( StandardLib, AssertionType, gTimeServicesBBTestConformanceAssertionGuid026, - L"RT.SetWakeupTime - Time.Year is 1997", + L"RT.SetWakeupTime - Time.Year is 1899", L"%a:%d:Status - %r", __FILE__, (UINTN)__LINE__, @@ -852,7 +852,7 @@ BBTestSetWakeupTimeConsistencyTest ( ); =20 Time =3D OldTime; - Time.Year =3D 2100; + Time.Year =3D 10000; Status =3D gtRT->SetWakeupTime ( TRUE, &Time @@ -866,7 +866,7 @@ BBTestSetWakeupTimeConsistencyTest ( StandardLib, AssertionType, gTimeServicesBBTestConformanceAssertionGuid027, - L"RT.SetWakeupTime - Time.Year is 2100", + L"RT.SetWakeupTime - Time.Year is 10000", L"%a:%d:Status - %r", __FILE__, (UINTN)__LINE__, --=20 2.32.0