* [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue
@ 2021-11-11 19:49 Michael D Kinney
2021-11-12 10:03 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Michael D Kinney @ 2021-11-11 19:49 UTC (permalink / raw)
To: devel; +Cc: Gerd Hoffmann, Ard Biesheuvel, Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3731
Fix VS2019 NOOPT build issues with OvmfPkg/Microvm/MicrovmX64.dsc
by fixing typecast of MICROVM_GED_MMIO_BASE_REGS to a VOID *.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
OvmfPkg/Library/ResetSystemLib/ResetSystemLibMicrovm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLibMicrovm.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLibMicrovm.c
index 5c714cf06a54..94dc894ded73 100644
--- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLibMicrovm.c
+++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLibMicrovm.c
@@ -18,7 +18,7 @@
static UINTN MicrovmGedBase (VOID)
{
- VOID *Address = (VOID*) MICROVM_GED_MMIO_BASE_REGS;
+ VOID *Address = (VOID*)(UINTN) MICROVM_GED_MMIO_BASE_REGS;
if (EfiGoneVirtual ()) {
EfiConvertPointer (0, &Address);
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue
2021-11-11 19:49 [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue Michael D Kinney
@ 2021-11-12 10:03 ` Gerd Hoffmann
2021-11-12 16:16 ` Michael D Kinney
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2021-11-12 10:03 UTC (permalink / raw)
To: Michael D Kinney; +Cc: devel, Ard Biesheuvel, Jiewen Yao
On Thu, Nov 11, 2021 at 11:49:23AM -0800, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3731
>
> Fix VS2019 NOOPT build issues with OvmfPkg/Microvm/MicrovmX64.dsc
> by fixing typecast of MICROVM_GED_MMIO_BASE_REGS to a VOID *.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue
2021-11-12 10:03 ` Gerd Hoffmann
@ 2021-11-12 16:16 ` Michael D Kinney
2021-11-12 17:02 ` [edk2-devel] " Leif Lindholm
0 siblings, 1 reply; 4+ messages in thread
From: Michael D Kinney @ 2021-11-12 16:16 UTC (permalink / raw)
To: Gerd Hoffmann, leif@nuviainc.com, Andrew Fish (afish@apple.com),
Kinney, Michael D
Cc: devel@edk2.groups.io, Ard Biesheuvel, Yao, Jiewen
Hi Andrew and Leif,
Do you approve this patch for edk2-stable202111?
Thanks,
Mike
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Friday, November 12, 2021 2:04 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Re: [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue
>
> On Thu, Nov 11, 2021 at 11:49:23AM -0800, Michael D Kinney wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3731
> >
> > Fix VS2019 NOOPT build issues with OvmfPkg/Microvm/MicrovmX64.dsc
> > by fixing typecast of MICROVM_GED_MMIO_BASE_REGS to a VOID *.
> >
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue
2021-11-12 16:16 ` Michael D Kinney
@ 2021-11-12 17:02 ` Leif Lindholm
0 siblings, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2021-11-12 17:02 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: Gerd Hoffmann, Andrew Fish (afish@apple.com), Ard Biesheuvel,
Yao, Jiewen
On Fri, Nov 12, 2021 at 16:16:01 +0000, Michael D Kinney wrote:
> Hi Andrew and Leif,
>
> Do you approve this patch for edk2-stable202111?
I'm fine with that one.
Regards,
Leif
> Thanks,
>
> Mike
>
>
> > -----Original Message-----
> > From: Gerd Hoffmann <kraxel@redhat.com>
> > Sent: Friday, November 12, 2021 2:04 AM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>
> > Subject: Re: [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue
> >
> > On Thu, Nov 11, 2021 at 11:49:23AM -0800, Michael D Kinney wrote:
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3731
> > >
> > > Fix VS2019 NOOPT build issues with OvmfPkg/Microvm/MicrovmX64.dsc
> > > by fixing typecast of MICROVM_GED_MMIO_BASE_REGS to a VOID *.
> > >
> > > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-12 17:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-11 19:49 [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue Michael D Kinney
2021-11-12 10:03 ` Gerd Hoffmann
2021-11-12 16:16 ` Michael D Kinney
2021-11-12 17:02 ` [edk2-devel] " Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox